Skip to content

Conversation

@djeong20
Copy link
Contributor

@djeong20 djeong20 commented Sep 4, 2025

This PR addresses issue #3417 by enabling OpenCL support on Android, which was previously disabled.

This patch verifies build arguments for android_test and ensures OpenCL libraries are correctly built and included.

Self-evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meson.build file is unused since we rely on ndk-build, so it is being removed.

Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@dkjung dkjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale label Oct 2, 2025
@github-actions
Copy link

github-actions bot commented Oct 5, 2025

This PR was closed because it has been stalled for 3 days with no activity.

@github-actions github-actions bot closed this Oct 5, 2025
@djeong20 djeong20 removed the Stale label Oct 15, 2025
@djeong20 djeong20 reopened this Oct 15, 2025
This PR addresses issue nnstreamer#3417 by enabling OpenCL support on Android, which was previously disabled.

This patch verifies build arguments for android_test and ensures OpenCL libraries are correctly built and included.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
Copy link

@haehun haehun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Need Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants