Skip to content

Add Fp16 support on windows #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Fp16 support on windows #3468

wants to merge 1 commit into from

Conversation

@gkisalapl
Copy link
Contributor 

This PR make possible to perform windows build with FP16
enabled, uint16_t is used as FP16 storage only type

@gkisalapl gkisalapl mentioned this pull request Sep 9, 2025
Closed
@gkisalapl gkisalapl force-pushed the fp16_windows_2 branch 2 times, most recently from b67cc38 to 70ca8dc Compare September 9, 2025 13:02
@gkisalapl gkisalapl marked this pull request as ready for review September 9, 2025 14:30
@gkisalapl gkisalapl force-pushed the fp16_windows_2 branch 2 times, most recently from 4c9e2f3 to fd33815 Compare September 16, 2025 13:28
@gkisalapl gkisalapl changed the title Add Fp16 support on windows (depends on #3429) Add Fp16 support on windows Sep 16, 2025
@gkisalapl
Use uint16_t as fp16 storage type on windows
c05b20d 
This PR make possible to perform windows build with FP16
enabled, uint16_t is used as FP16 storage only type

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Grzegorz Kisala <[email protected]>
@gkisalapl
Copy link
Contributor Author

Changes moved to #3498

@gkisalapl gkisalapl closed this Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@DonghakPark DonghakPark Awaiting requested review from DonghakPark DonghakPark is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@skykongkong8 skykongkong8 Awaiting requested review from skykongkong8 skykongkong8 is a code owner

@djeong20 djeong20 Awaiting requested review from djeong20 djeong20 is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang is a code owner

@dkjung dkjung Awaiting requested review from dkjung dkjung is a code owner

@haehun haehun Awaiting requested review from haehun haehun is a code owner

Assignees

No one assigned

Labels

Need Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gkisalapl