Skip to content

Conversation

@DonghakPark
Copy link
Member

Dependency of the PR

None

Commits to be reviewed in this PR

05efa65 – Add Layer Prop & Add Layer Func

Commit Message:
[FSU] Add Layer Prop & Add Layer Func

Summary of Changes:

  • Added FsuWeight property (fsu_weight) allowing layers to expose a virtual weight flag via withKey.
  • Extended LayerDevel with virtual method activateWeight(RunLayerContext &context).
  • Implemented LayerNode::activateWeight() forwarding to the layer.
  • Updated common property headers/cpp and layer node interfaces.

Self evaluation:

  1. Build test: [X] Passed [ ] Failed [ ] Skipped
  2. Run test: [X] Passed [ ] Failed [ ] Skipped

Signed-off-by: Donghak PARK [email protected]

3a96401 – Add WeightPreFetch in network_graph

Commit Message:
[FSU] Add WeightPreFetch in network_graph

Summary of Changes:

  • Added NetworkGraph::WeightPreFetch(unsigned int order, unsigned int lookahead) which triggers activateWeight() on the specified layer node, enabling weight prefetching.
  • Updated header documentation accordingly.

Self evaluation:

  1. Build test: [X] Passed [ ] Failed [ ] Skipped
  2. Run test: [X] Passed [ ] Failed [ ] Skipped

Signed-off-by: Donghak PARK [email protected]

Summary

  • Commit 05efa65: Introduces the fsu_weight property and the activateWeight hook, allowing layers to be configured with the withKey mechanism for virtual weight handling.
  • Commit 3a96401: Provides a WeightPreFetch API in NetworkGraph that calls the new activateWeight hook, laying groundwork for weight prefetching.

Important Note: The actual tensor activation/deactivation logic is implemented in a separate PR and is not functional yet. This PR only adds the API hooks and documentation; the underlying behavior will be completed later.

Signed-off-by: Donghak PARK [email protected]

Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good patch to enable prefetching the weights at the graph level.
I have some questions on your PR. Could you give me answer?

@DonghakPark DonghakPark self-assigned this Sep 18, 2025
Add WeightPreFetch
- activateWeight with mmap at network_graph

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Add Layer Prop & Add Layer Func
- fsu_weight : true | false
- layer_node -> activateWeight

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Update Name for convention & remove unused param

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale label Oct 9, 2025
@github-actions
Copy link

This PR was closed because it has been stalled for 3 days with no activity.

@github-actions github-actions bot closed this Oct 12, 2025
@DonghakPark DonghakPark reopened this Oct 13, 2025
@github-actions github-actions bot removed the Stale label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants