-
Notifications
You must be signed in to change notification settings - Fork 94
[FSU] Add fsu_weight Prop & WeightPrefetch() at Network_Graph #3469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
05efa65 to
f2aa1dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good patch to enable prefetching the weights at the graph level.
I have some questions on your PR. Could you give me answer?
f2aa1dc to
c7179cd
Compare
Add WeightPreFetch - activateWeight with mmap at network_graph **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghak PARK <[email protected]>
Add Layer Prop & Add Layer Func - fsu_weight : true | false - layer_node -> activateWeight **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghak PARK <[email protected]>
Update Name for convention & remove unused param **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghak PARK <[email protected]>
1dc5e6c to
2cf2725
Compare
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
|
This PR was closed because it has been stalled for 3 days with no activity. |
Dependency of the PR
None
Commits to be reviewed in this PR
05efa65 – Add Layer Prop & Add Layer Func
Commit Message:
[FSU] Add Layer Prop & Add Layer Func
Summary of Changes:
FsuWeightproperty (fsu_weight) allowing layers to expose a virtual weight flag viawithKey.LayerDevelwith virtual methodactivateWeight(RunLayerContext &context).LayerNode::activateWeight()forwarding to the layer.Self evaluation:
Signed-off-by: Donghak PARK [email protected]
3a96401 – Add WeightPreFetch in network_graph
Commit Message:
[FSU] Add WeightPreFetch in network_graph
Summary of Changes:
NetworkGraph::WeightPreFetch(unsigned int order, unsigned int lookahead)which triggersactivateWeight()on the specified layer node, enabling weight prefetching.Self evaluation:
Signed-off-by: Donghak PARK [email protected]
Summary
fsu_weightproperty and theactivateWeighthook, allowing layers to be configured with thewithKeymechanism for virtual weight handling.WeightPreFetchAPI inNetworkGraphthat calls the newactivateWeighthook, laying groundwork for weight prefetching.Important Note: The actual tensor activation/deactivation logic is implemented in a separate PR and is not functional yet. This PR only adds the API hooks and documentation; the underlying behavior will be completed later.
Signed-off-by: Donghak PARK [email protected]