Disable saving and loading kernel's binary from cache #3505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-pokorski-samsung
requested review from
DonghakPark,
EunjuYang,
SeoHyungjun,
again4you,
anyj0527,
baek2sm,
djeong20,
dkjung,
gichan-jang,
haehun,
jaeyun-jung,
jihochu,
jijoongmoon,
leemgs,
lhs8928,
myungjoo,
skykongkong8,
songgot and
wooksong
as code owners
songgot
reviewed
Sep 22, 2025
**Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Piotr Pokorski <[email protected]>
p-pokorski-samsung
force-pushed
the
revert-kernel-caching
branch
from
13be106 to
d060372
Compare
mwlasiuk
reviewed
Oct 1, 2025
Comment on lines
+34
to
+38
| #if KERNEL_CACHE | ||
| static constexpr bool KERNEL_CACHE_ENABLED = true; | ||
| #else | ||
| static constexpr bool KERNEL_CACHE_ENABLED = false; | ||
| #endif |
There was a problem hiding this comment.
Maybe different naming convention for static constexprs so the are not confused with defines (all uppercase)?
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
|
This PR was closed because it has been stalled for 3 days with no activity. |
|
@p-pokorski-samsung, Could you please rebase this pull request? Thank you in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-evaluation:
Dependency of the PR
Commits to be reviewed in this PR
{commit-1}
{commit message}
Self evaluation:
Signed-off-by: {your_name} <{your_email}>
{commit-2}
{commit message}
Self evaluation:
Signed-off-by: {your_name} <{your_email}>
Summary
Signed-off-by: {your_name} <{your_email}>