Skip to content

Make dispatching readable #3515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make dispatching readable #3515

wants to merge 1 commit into from

Conversation

@mwlasiuk
Copy link
Contributor

@mwlasiuk mwlasiuk commented Sep 26, 2025 •
edited
Loading

  • Use struct with named fields instead of 2 arrays of 3 int
  • This way dispatching kernels is more readable and less error prone

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: mwlasiuk [email protected]

@mwlasiuk mwlasiuk marked this pull request as ready for review September 29, 2025 11:02
skykongkong8
skykongkong8 reviewed Sep 30, 2025
View reviewed changes
Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check for Android build failure

@mwlasiuk
Copy link
Contributor Author

Please check for Android build failure

Done

@github-actions
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale label Oct 15, 2025
@mwlasiuk
Make dispatching readable
51b7c43 
- Use struct with named fielkds instead of 2 arrays of 3 ints

Signed-off-by: mwlasiuk <[email protected]>
@github-actions github-actions bot removed the Stale label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skykongkong8 skykongkong8 skykongkong8 approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@DonghakPark DonghakPark Awaiting requested review from DonghakPark DonghakPark is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@djeong20 djeong20 Awaiting requested review from djeong20 djeong20 is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang is a code owner

@dkjung dkjung Awaiting requested review from dkjung dkjung is a code owner

@haehun haehun Awaiting requested review from haehun haehun is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Need Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mwlasiuk @skykongkong8