Skip to content

Bugfix adamw #3527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bugfix adamw #3527

wants to merge 2 commits into from

Conversation

@lhs8928
Copy link
Contributor

@lhs8928 lhs8928 commented Oct 20, 2025

Commit 1:

[test] test value by value instead of using mse

 - Compare value by value for element of full precision tensor
 - Following tests had a issues with training so fixed it (sine, cosine, tangent, neg, pow, sqrt)
 - Following tests still had a issues.So temporarily disable this tests. (reduce_sum, split_and_join_dangle, grucell_fc)

Signed-off-by: Hyeonseok Lee <[email protected]>

Commit 2:

[optimizer] bugfix adamw

 - Adamw optimizer has been functioning like Adam optimizer so far.

Signed-off-by: Hyeonseok Lee <[email protected]>

@lhs8928
[test] test value by value instead of using mse
4d6aaee 
 - Compare value by value for element of full precision tensor
 - Following tests had a issues with training so fixed it (sine, cosine, tangent, neg, pow, sqrt)
 - Following tests still had a issues.So temporarily disable this tests. (reduce_sum, split_and_join_dangle, grucell_fc)

Signed-off-by: Hyeonseok Lee <[email protected]>
@lhs8928
[optimizer] bugfix adamw
953e914 
 - Adamw optimizer has been functioning like Adam optimizer so far.

Signed-off-by: Hyeonseok Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@DonghakPark DonghakPark Awaiting requested review from DonghakPark DonghakPark is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@skykongkong8 skykongkong8 Awaiting requested review from skykongkong8 skykongkong8 is a code owner

@djeong20 djeong20 Awaiting requested review from djeong20 djeong20 is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang is a code owner

@dkjung dkjung Awaiting requested review from dkjung dkjung is a code owner

@haehun haehun Awaiting requested review from haehun haehun is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Need Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lhs8928