Fix static windows build #3528
Fix static windows build #3528
Conversation
gkisalapl
force-pushed
the
fix_static_windows_build
branch
4 times, most recently
from
b8da0e6 to
954a610
Compare
gkisalapl
requested review from
DonghakPark,
EunjuYang,
SeoHyungjun,
again4you,
anyj0527,
baek2sm,
djeong20,
dkjung,
gichan-jang,
haehun,
jaeyun-jung,
jihochu,
jijoongmoon,
leemgs,
lhs8928,
myungjoo,
skykongkong8,
songgot and
wooksong
as code owners
| install_dir: application_install_dir, | ||
| link_args: [tokenizer_path], | ||
| cpp_args: '-DPLUGGABLE' | ||
| cpp_args: cpp_args |
There was a problem hiding this comment.
Is it okay to have the same naming?
There was a problem hiding this comment.
I think it's ok, it's key - value relation
meson_options.txt
Outdated
| option('libiomp_root', type:'string', value: './libiomp_win') | ||
|
|
||
| # use layers as pluggable modules | ||
| option('enable-pluggable', type: 'boolean', value: true) |
There was a problem hiding this comment.
how about adding default_library=static and enable-pluggable=false to windows-native.ini?
There was a problem hiding this comment.
Could the following condition be possible?
default_library is static, and enable-pluggable is true; default_library is not static, and enable-pluggable is false.
If this is not feasible, we might need to remove the new option.
There was a problem hiding this comment.
configuration in which default_library is static, and enable-pluggable is true would not work
There was a problem hiding this comment.
In that case, we could remove this option and revise it.
cpp_args = []
if get_option('default_library') != 'static'
cpp_args += [ '-DPLUGGABLE' ]
endif
fba2842 to
2ab7b50
Compare
Make possible to build nntrainer in static or shared version on Windows platform **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Grzegorz Kisala <[email protected]>
gkisalapl
force-pushed
the
fix_static_windows_build
branch
from
2ab7b50 to
deeafc9
Compare
2 participants
Make possible to build nntrainer in static or shared version on
Windows platform
Use following commandt for static build:
meson setup --wipe --native-file windows-native.ini builddir -Ddefault_library=static -Denable-pluggable=false -Denable-opencl=true
meson compile -C builddir