Support Attachements #381
Draft
Support Attachements #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
A couple things to note:
|
no23reason
reviewed
Apr 25, 2021
| // TODO: use event.test.startedAt in case of re-reuns | ||
| this.testAttachmentMappings[testName][0] = attachmentList; | ||
|
|
||
| this.global.saveAttachmentToTrx = (attachmentPath: string) => { |
Owner
There was a problem hiding this comment.
What does this line do? Where does the saveAttachmentToTrx get called?
no23reason
reviewed
Apr 25, 2021
| testResult.ancestorTitles && testResult.ancestorTitles.length | ||
| ? `${testResult.ancestorTitles.join(" / ")} / ${testResult.title}` | ||
| : testResult.title; | ||
| export const getFullTestName = (ancestorTitles: string[], testResultTitle: string): string => |
Owner
There was a problem hiding this comment.
Can we use the single testResult parameter like before? When you call this, you are passing two properties of the testResult so why not pass the whole thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't done full testing yet,