added format model data module#361
Open
anna-abelman wants to merge 7 commits intofishset-lite-devfrom
Open
Conversation
Paul-Carvalho
requested changes
Feb 13, 2026
Collaborator
Paul-Carvalho
left a comment
Paul-Carvalho
left a comment
There was a problem hiding this comment.
Hey Anna, this looks really good! Just a few minor changes requested here.
Merge branch 'fishset-lite-dev' of github.com:noaa-nwfsc/FishSET into fsl-format-model-gui # Conflicts: # tests/testthat/testdata/FishSETFolder/s1/fishset_db.sqlite
Paul-Carvalho
requested changes
Feb 25, 2026
| df <- df %>% | ||
| rename(!!zone_id := zones) | ||
| # Save settings | ||
| settings <- as.list(match.call())[-1] |
Collaborator
There was a problem hiding this comment.
Did settings <- as.list(match.call())[-1] not work with the GUI? This line should grab all of the function input as a list without having the list all the inputs manually.
If it didn't work for the GUI I think that's okay to list everything manually. It would be nice to use match.call() method because whenever the inputs change we don't have to manually change the settings list at the bottom of the script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know what you think about the module. Also I kept the aux and grid data there for users to select because I wasn't sure if they would always want the data to be included. It is an easy fix if you don't think it is necessary.
I found a way to get the aux column mismatch error to work but not sure if its the greatest method. The grid data mismatch is always fixed but only in the format_model_data() function.
I also went ahead and added the card overflow classes to the load data and select variables tabs since I was already in those making some edits. (Plus it has been bothering me forever...)