Add markers #59
Open
Add markers #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated tests to check if all tests pass when adding marker - all tests pass
felix-andreas
commented
May 26, 2020
… into add-markers-tom
- updated tests - corrected version in test_undefined
… into add-markers-tom
a default value so it is not mandatory
… into add-markers-tom
- Needed updating test file for cavities: f -> frequency
* updated parse to deal with array values * updated test example * tested maxiv madx and elegant conversion both worked but result in different json files
Closed
- removed min value from schema for length, SLS has negativ drifts
… into add-markers-tom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
I opened a PR to make the branch more visible.