feat: add managed vault protobuf definitions#56
feat: add managed vault protobuf definitions#56johnletey merged 28 commits intonoble-assets:managed-vaultfrom
Conversation
Clarify that there is only 1 vault and multiple remote positions
Some clarifications
Spec for the NAV oracle
Co-authored-by: Justin Tieri <37750742+jtieri@users.noreply.github.com>
…ation-for-emergency-mode docs: describe emergency mode in vaults v2 overview
Co-authored-by: John Letey <j@letey.de>
Co-authored-by: John Letey <j@letey.de>
Co-authored-by: John Letey <j@letey.de>
Co-authored-by: John Letey <j@letey.de>
Co-authored-by: John Letey <j@letey.de>
Co-authored-by: John Letey <j@letey.de>
Co-authored-by: John Letey <j@letey.de>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cbrit
left a comment
cbrit
left a comment
There was a problem hiding this comment.
Some items pertaining to the vaults, tx, and query protos. Mostly to do with inconsistencies against the spec, but also some questions.
| rpc ProcessWithdrawalQueue(MsgProcessWithdrawalQueue) returns (MsgProcessWithdrawalQueueResponse); | ||
|
|
||
| // Update vault configuration (authority only) | ||
| rpc UpdateVaultConfig(MsgUpdateVaultConfig) returns (MsgUpdateVaultConfigResponse); |
| string total_value = 3; // deposit + yield | ||
| string unrealized_gain = 4; | ||
| string locked_amount = 5; // amount in withdrawal queue | ||
| } |
There was a problem hiding this comment.
Different field names than the UserShares in the queries spec
| string yield_rate = 2; // current APY | ||
| CheckResultsView checks = 3; | ||
| repeated string warnings = 4; | ||
| } |
There was a problem hiding this comment.
QuerySimulateDepositResponse has some different field names than in the spec
| string principal_portion = 2; | ||
| string yield_portion = 3; | ||
| uint64 queue_position = 4; | ||
| string estimated_fulfillment_time = 5; // seconds |
There was a problem hiding this comment.
There are also some differences in the field names compared to the spec here
| option go_package = "dollar.noble.xyz/v2/types/vaults/v2"; | ||
|
|
||
| // Query defines the gRPC querier service for V2 vaults | ||
| service Query { |
There was a problem hiding this comment.
Missing a VaultStats handler mentioned in the spec
johnletey
changed the title
4 participants
This PR adds the v2 proto definitions for managed vaults functionality.
Changes
All proto files have been formatted using buf.