Skip to content

fix: set bridge during initialization to make it upgradeable#63

Merged
keyleu merged 4 commits intocontractsfrom
fix-contract
Nov 18, 2025
Merged

fix: set bridge during initialization to make it upgradeable#63
keyleu merged 4 commits intocontractsfrom
fix-contract

Conversation

@keyleu
Copy link
Copy Markdown

@keyleu keyleu commented Nov 18, 2025

Moved the bridge address calculation in the initializer to make it work with upgradeable patterns.

Added UUPSUpgradeability because it's more gas-efficient and recommended in general (modern approach).

Added also a few extra tests to test upgrading works as expected and that the yield of the bridge is claimed correctly and sent to the owner as expected.

@keyleu keyleu requested review from 0xstepit and johnletey November 18, 2025 11:36
Copy link
Copy Markdown
Member

@johnletey johnletey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @keyleu! Left a few comments 😄

Comment thread contracts/test/NobleDollar.t.sol Outdated
Comment thread contracts/test/NobleDollar.t.sol Outdated
Comment thread contracts/src/HyperliquidNobleDollar.sol Outdated
Comment thread contracts/src/NobleDollar.sol Outdated
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 18, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-contract

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@keyleu keyleu requested a review from johnletey November 18, 2025 12:21
Comment thread contracts/test/NobleDollar.t.sol
@keyleu keyleu merged commit dce538f into contracts Nov 18, 2025
7 checks passed
@keyleu keyleu deleted the fix-contract branch November 18, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants