feat: remove heighliner and replace with dockerfile#557
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
boojamya
left a comment
There was a problem hiding this comment.
@johnletey this looks great! Added one more comment to help streamline.
However I cannot seem to get this to work locally!
For example:
make local-image
go test -timeout 5m -run TestCCTP_UpdateOwner ./e2e -v -count=1
I'm a bit stumped here, running that test (and other tests) produces:
failed to start chains: failed to start chain noble-1: overwriting config/app.toml: Error response from daemon: No such container
My original hunch was UID perm issues with the image, so I modified the docker image similarly to how we used to have it adding in the user. Ref:
https://github.com/noble-assets/noble/blob/c83109d0b64758ceb56bfcbc440248f65bfbda23/Dockerfile
This did not fix it.
I'm a bit stumped as I can see this is working in CI.
Is this just a me issue? Are you able to run and pass tests locally?
boojamya
left a comment
There was a problem hiding this comment.
Left one final comment. Feel free to ignore it but I think we could streamline this even more.
RIP Heighliner!
Approving!
No description provided.