Skip to content

feat: remove heighliner and replace with dockerfile#557

Merged
johnletey merged 13 commits into
v11from
john/remove-heighliner
Sep 5, 2025
Merged

feat: remove heighliner and replace with dockerfile#557
johnletey merged 13 commits into
v11from
john/remove-heighliner

Conversation

@johnletey

Copy link
Copy Markdown
Member

No description provided.

@johnletey johnletey added this to the v10.0.0 Stratum milestone Jun 4, 2025
@johnletey johnletey self-assigned this Jun 4, 2025
@coderabbitai

coderabbitai Bot commented Jun 4, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch john/remove-heighliner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Comment thread Dockerfile
@johnletey johnletey removed this from the v10.0.0 Stratum milestone Jun 6, 2025
Base automatically changed from v10 to main June 6, 2025 11:04
@johnletey
johnletey changed the base branch from main to v11 August 28, 2025 16:23
@johnletey
johnletey marked this pull request as ready for review August 28, 2025 17:35
@johnletey
johnletey requested a review from a team as a code owner August 28, 2025 17:35
@johnletey johnletey added this to the v11.0.0 Flux milestone Aug 28, 2025
@johnletey
johnletey requested a review from boojamya August 29, 2025 07:40

@boojamya boojamya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnletey this looks great! Added one more comment to help streamline.
However I cannot seem to get this to work locally!

For example:
make local-image
go test -timeout 5m -run TestCCTP_UpdateOwner ./e2e -v -count=1

I'm a bit stumped here, running that test (and other tests) produces:
failed to start chains: failed to start chain noble-1: overwriting config/app.toml: Error response from daemon: No such container

My original hunch was UID perm issues with the image, so I modified the docker image similarly to how we used to have it adding in the user. Ref:
https://github.com/noble-assets/noble/blob/c83109d0b64758ceb56bfcbc440248f65bfbda23/Dockerfile

This did not fix it.
I'm a bit stumped as I can see this is working in CI.

Is this just a me issue? Are you able to run and pass tests locally?

Comment thread .github/workflows/e2e-tests.yaml Outdated
@johnletey
johnletey requested a review from boojamya September 4, 2025 15:57
boojamya
boojamya previously approved these changes Sep 4, 2025

@boojamya boojamya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one final comment. Feel free to ignore it but I think we could streamline this even more.
RIP Heighliner!
Approving!

Comment thread .github/workflows/e2e-tests.yaml Outdated
@johnletey
johnletey merged commit d915cac into v11 Sep 5, 2025
39 checks passed
@johnletey
johnletey deleted the john/remove-heighliner branch September 5, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants