chore: add license check CI action#579
Conversation
WalkthroughA new Makefile target named check-license is added. It invokes go-license with the repository’s existing configuration and FILES variable, using the --verify flag. No existing targets are modified. The target must be explicitly run and returns failure on non-compliant license headers. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
Makefile (3)
72-74: Reorder flags to avoid potential CLI parsing issues.Some CLIs require all flags before positional args. To be safe, pass
--verifybefore$(FILES).-check-license: - @go-license --config .github/license.yml $(FILES) --verify +check-license: + @go-license --config .github/license.yml --verify $(FILES)
102-102: Mark the new target as phony.Add
check-licenseto.PHONYto prevent Make from treating a same-named file as up-to-date, which could accidentally skip the check.-.PHONY: license format lint build install local-image +.PHONY: license check-license format lint build install local-image
72-74: Confirm CI wiring calls this target.The PR description mentions adding a CI action. Ensure your workflow actually runs
make check-license(or the equivalent) so verification happens on PRs.Happy to draft a minimal GitHub Actions job that installs the tool and runs this target if you’d like.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
.github/workflows/check-license.yamlis excluded by!**/*.yaml
📒 Files selected for processing (1)
Makefile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: prepare
- GitHub Check: build
- GitHub Check: build-and-push-image
This PR adds the functionality to run the
go-licensetool in CI.