Skip to content

chore: add license check CI action#579

Merged
MalteHerrmann merged 2 commits into
mainfrom
add-license-check
Aug 22, 2025
Merged

chore: add license check CI action#579
MalteHerrmann merged 2 commits into
mainfrom
add-license-check

Conversation

@MalteHerrmann

Copy link
Copy Markdown
Contributor

This PR adds the functionality to run the go-license tool in CI.

@MalteHerrmann MalteHerrmann self-assigned this Aug 21, 2025
@MalteHerrmann
MalteHerrmann requested a review from a team as a code owner August 21, 2025 18:11
@coderabbitai

coderabbitai Bot commented Aug 21, 2025

Copy link
Copy Markdown

Walkthrough

A new Makefile target named check-license is added. It invokes go-license with the repository’s existing configuration and FILES variable, using the --verify flag. No existing targets are modified. The target must be explicitly run and returns failure on non-compliant license headers.

Changes

Cohort / File(s) Summary
Build tooling
Makefile
Added target check-license running go-license --config .github/license.yml $(FILES) --verify; no other targets changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at headers bold,
A hop through files, both new and old—
“check-license,” I thump with glee,
Ensuring texts align with decree.
If lines go stray, I gently squeak,
Then nibble fixes, tidy and sleek. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-license-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
Makefile (3)

72-74: Reorder flags to avoid potential CLI parsing issues.

Some CLIs require all flags before positional args. To be safe, pass --verify before $(FILES).

-check-license:
-	@go-license --config .github/license.yml $(FILES) --verify
+check-license:
+	@go-license --config .github/license.yml --verify $(FILES)

102-102: Mark the new target as phony.

Add check-license to .PHONY to prevent Make from treating a same-named file as up-to-date, which could accidentally skip the check.

-.PHONY: license format lint build install local-image
+.PHONY: license check-license format lint build install local-image

72-74: Confirm CI wiring calls this target.

The PR description mentions adding a CI action. Ensure your workflow actually runs make check-license (or the equivalent) so verification happens on PRs.

Happy to draft a minimal GitHub Actions job that installs the tool and runs this target if you’d like.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5264ac1 and 86b3767.

⛔ Files ignored due to path filters (1)
  • .github/workflows/check-license.yaml is excluded by !**/*.yaml
📒 Files selected for processing (1)
  • Makefile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: prepare
  • GitHub Check: build
  • GitHub Check: build-and-push-image

@MalteHerrmann
MalteHerrmann merged commit b636f3f into main Aug 22, 2025
39 checks passed
@MalteHerrmann
MalteHerrmann deleted the add-license-check branch August 22, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants