Skip to content

chore: bump globalfee module#582

Merged
johnletey merged 1 commit into
mainfrom
john/bump-globalfee
Aug 25, 2025
Merged

chore: bump globalfee module#582
johnletey merged 1 commit into
mainfrom
john/bump-globalfee

Conversation

@johnletey

Copy link
Copy Markdown
Member

No description provided.

@johnletey johnletey self-assigned this Aug 25, 2025
@johnletey
johnletey requested a review from a team as a code owner August 25, 2025 18:26
@coderabbitai

coderabbitai Bot commented Aug 25, 2025

Copy link
Copy Markdown

Walkthrough

Introduces v10.1.1 release notes and dependency updates. Adds changelog entries documenting a non-consensus patch relevant to validators and bumps noble-assets/globalfee from v1.0.0 to v1.0.1. Updates api/generate.sh to export the new globalfee version. No logic or public API changes.

Changes

Cohort / File(s) Summary
Release notes (v10.1.1)
CHANGELOG.md, .changelog/v10.1.1/summary.md
Added v10.1.1 entry: non-consensus patch for v10.1 Ember, dated Aug 25, 2025; indicates validator relevance.
Dependency-specific changelog
.changelog/v10.1.1/dependencies/582-bump-globalfee.md
Added entry documenting GlobalFee bump to v1.0.1 with reference to PR #582 and mempool bypass checks hardening.
Build/export script
api/generate.sh
Updated buf export for noble-assets/globalfee from v1.0.0 to v1.0.1; no other changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • boojamya
  • g-luca

Poem

Patch hops softly through the Ember glade,
Notes penned neat, dependencies relaid.
GlobalFee nudged—mempools stand guard,
Validators wink, their duty not hard.
Thump-thump go paws on the CI track,
v10.1.1—carrots packed! 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch john/bump-globalfee

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@johnletey
johnletey requested a review from jtieri August 25, 2025 18:27

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
.changelog/v10.1.1/summary.md (1)

1-1: Suppress MD036 for italicized dates in changelog summary
We’ve confirmed an MD036 violation in .changelog/v10.1.1/summary.md (line 1): the date is formatted as emphasized text instead of a heading. To satisfy markdownlint while preserving the project’s convention of italicized dates, either convert the date into a heading or disable MD036 for this file.

Example—suppress MD036 around the date:

+<!-- markdownlint-disable MD036 -->
 *Aug 25, 2025*
+<!-- markdownlint-enable MD036 -->

Or convert the date to a top-level heading:

-*Aug 25, 2025*
+# Aug 25, 2025
.changelog/v10.1.1/dependencies/582-bump-globalfee.md (1)

1-1: Minor wording nit (optional): “checks for bypass messages.”

“Checks of bypass messages” reads a bit stiff; “checks for bypass messages” aligns better with common phrasing. Functionally the entry is great either way.

- - Bump GlobalFee to [`v1.0.1`](https://github.com/noble-assets/globalfee/releases/tag/v1.0.1) to harden mempool checks of bypass messages. ([#582](https://github.com/noble-assets/noble/pull/582))
+ - Bump GlobalFee to [`v1.0.1`](https://github.com/noble-assets/globalfee/releases/tag/v1.0.1) to harden mempool checks for bypass messages. ([#582](https://github.com/noble-assets/noble/pull/582))
CHANGELOG.md (2)

5-5: markdownlint MD036: optional suppression for italicized dates.

Given the historic use of italic dates in this file, consider disabling MD036 locally in this section to avoid linter noise, or keep as-is if the style guide favors italics.

+<!-- markdownlint-disable MD036 -->
 *Aug 25, 2025*
+<!-- markdownlint-enable MD036 -->

13-13: Tiny phrasing improvement (optional).

Same nit as the dependencies file: “checks for” reads more naturally.

- - Bump GlobalFee to [`v1.0.1`](https://github.com/noble-assets/globalfee/releases/tag/v1.0.1) to harden mempool checks of bypass messages. ([#582](https://github.com/noble-assets/noble/pull/582))
+ - Bump GlobalFee to [`v1.0.1`](https://github.com/noble-assets/globalfee/releases/tag/v1.0.1) to harden mempool checks for bypass messages. ([#582](https://github.com/noble-assets/noble/pull/582))
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 40e48da and 8f82802.

⛔ Files ignored due to path filters (4)
  • api/config.json is excluded by !**/*.json
  • api/gen/swagger.yaml is excluded by !**/gen/**, !**/*.yaml, !**/gen/**
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
📒 Files selected for processing (4)
  • .changelog/v10.1.1/dependencies/582-bump-globalfee.md (1 hunks)
  • .changelog/v10.1.1/summary.md (1 hunks)
  • CHANGELOG.md (1 hunks)
  • api/generate.sh (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
.changelog/v10.1.1/summary.md

1-1: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

CHANGELOG.md

5-5: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: prepare
  • GitHub Check: build-and-push-image
🔇 Additional comments (3)
.changelog/v10.1.1/summary.md (1)

3-5: Changelog entry reads clearly and matches the PR scope.

Non-consensus patch note and validator relevance look consistent with prior entries.

api/generate.sh (1)

16-16: Bump to globalfee v1.0.1 confirmed; no go.mod or go.work to update

  • No go.mod or go.work files found in the repository.
  • All v1.0.0 references have been removed and the buf export line correctly uses v1.0.1.
CHANGELOG.md (1)

3-14: v10.1.1 section looks correct and placed appropriately.

  • Version header, date, and “validators-only” scope match the PR intent.
  • Dependency note links to the correct release and PR.

@johnletey
johnletey merged commit 434f15e into main Aug 25, 2025
39 checks passed
@johnletey
johnletey deleted the john/bump-globalfee branch August 25, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants