chore: bump globalfee module#582
Conversation
WalkthroughIntroduces v10.1.1 release notes and dependency updates. Adds changelog entries documenting a non-consensus patch relevant to validators and bumps noble-assets/globalfee from v1.0.0 to v1.0.1. Updates api/generate.sh to export the new globalfee version. No logic or public API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.changelog/v10.1.1/summary.md (1)
1-1: Suppress MD036 for italicized dates in changelog summary
We’ve confirmed an MD036 violation in.changelog/v10.1.1/summary.md(line 1): the date is formatted as emphasized text instead of a heading. To satisfy markdownlint while preserving the project’s convention of italicized dates, either convert the date into a heading or disable MD036 for this file.Example—suppress MD036 around the date:
+<!-- markdownlint-disable MD036 --> *Aug 25, 2025* +<!-- markdownlint-enable MD036 -->Or convert the date to a top-level heading:
-*Aug 25, 2025* +# Aug 25, 2025.changelog/v10.1.1/dependencies/582-bump-globalfee.md (1)
1-1: Minor wording nit (optional): “checks for bypass messages.”“Checks of bypass messages” reads a bit stiff; “checks for bypass messages” aligns better with common phrasing. Functionally the entry is great either way.
- - Bump GlobalFee to [`v1.0.1`](https://github.com/noble-assets/globalfee/releases/tag/v1.0.1) to harden mempool checks of bypass messages. ([#582](https://github.com/noble-assets/noble/pull/582)) + - Bump GlobalFee to [`v1.0.1`](https://github.com/noble-assets/globalfee/releases/tag/v1.0.1) to harden mempool checks for bypass messages. ([#582](https://github.com/noble-assets/noble/pull/582))CHANGELOG.md (2)
5-5: markdownlint MD036: optional suppression for italicized dates.Given the historic use of italic dates in this file, consider disabling MD036 locally in this section to avoid linter noise, or keep as-is if the style guide favors italics.
+<!-- markdownlint-disable MD036 --> *Aug 25, 2025* +<!-- markdownlint-enable MD036 -->
13-13: Tiny phrasing improvement (optional).Same nit as the dependencies file: “checks for” reads more naturally.
- - Bump GlobalFee to [`v1.0.1`](https://github.com/noble-assets/globalfee/releases/tag/v1.0.1) to harden mempool checks of bypass messages. ([#582](https://github.com/noble-assets/noble/pull/582)) + - Bump GlobalFee to [`v1.0.1`](https://github.com/noble-assets/globalfee/releases/tag/v1.0.1) to harden mempool checks for bypass messages. ([#582](https://github.com/noble-assets/noble/pull/582))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (4)
api/config.jsonis excluded by!**/*.jsonapi/gen/swagger.yamlis excluded by!**/gen/**,!**/*.yaml,!**/gen/**go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum,!**/*.sum
📒 Files selected for processing (4)
.changelog/v10.1.1/dependencies/582-bump-globalfee.md(1 hunks).changelog/v10.1.1/summary.md(1 hunks)CHANGELOG.md(1 hunks)api/generate.sh(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
.changelog/v10.1.1/summary.md
1-1: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
CHANGELOG.md
5-5: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build
- GitHub Check: prepare
- GitHub Check: build-and-push-image
🔇 Additional comments (3)
.changelog/v10.1.1/summary.md (1)
3-5: Changelog entry reads clearly and matches the PR scope.Non-consensus patch note and validator relevance look consistent with prior entries.
api/generate.sh (1)
16-16: Bump to globalfee v1.0.1 confirmed; no go.mod or go.work to update
- No
go.modorgo.workfiles found in the repository.- All
v1.0.0references have been removed and thebuf exportline correctly usesv1.0.1.CHANGELOG.md (1)
3-14: v10.1.1 section looks correct and placed appropriately.
- Version header, date, and “validators-only” scope match the PR intent.
- Dependency note links to the correct release and PR.
No description provided.