feat: v10.1.2 patch release

[johnletey]

No description provided.

[coderabbitai]

Walkthrough

Adds changelog entries for v10.1.2; bumps dependencies (Forwarding to v2.0.3, CometBFT to v0.38.19); wires ForwardingKeeper into the ante handler; extends permission checks to a new swap message; updates API generation script; and adds a mainnet height-gated Forwarding allowed-denoms update in pre-block.

Changes

Cohort / File(s)	Summary
Release notes .changelog/v10.1.2/summary.md, .changelog/v10.1.2/dependencies/600-bump-comet.md, .changelog/v10.1.2/dependencies/600-bump-forwarding.md, CHANGELOG.md	Adds v10.1.2 changelog, documenting CometBFT v0.38.19 and Forwarding v2.0.3 updates and noting consensus-breaking patch status.
Ante wiring: Forwarding integration ante.go	Introduces ForwardingKeeper into HandlerOptions, enforces non-nil in NewAnteHandler, and routes signature verification through forwarding’s decorator.
Permissioned liquidity check extension ante_permissioned_liquidity.go	Adds permission validation for swaptypes.MsgWithdrawRewards alongside existing liquidity messages.
App wiring and pre-block upgrade hook app.go	Includes ForwardingKeeper in ante options; adds mainnet height-gated call to ForwardingKeeper.SetAllowedDenoms during PreBlocker; imports updated.
API generation dependency bump api/generate.sh	Updates forwarding export reference from v2.0.2 to v2.0.3.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Tx as Transaction
  participant Ante as AnteHandler
  participant Fwd as ForwardingKeeper
  participant Bank as BankKeeper

  Note over Ante: Signature verification path updated
  Tx->>Ante: DeliverTx
  Ante->>Bank: Access balances (as needed)
  Ante->>Fwd: forwarding.NewSigVerificationDecorator(...).VerifySig()
  Fwd-->>Ante: Sig result
  Ante-->>Tx: Continue or fail

Loading

sequenceDiagram
  autonumber
  participant ABCI as CometBFT ABCI
  participant App as App PreBlocker
  participant Fwd as ForwardingKeeper
  participant Auth as AuthorityModuleAddress

  ABCI->>App: BeginBlock/PrepareProposal (Pre-block)
  alt mainnet && height == 36887000
    Note over App,Fwd: Height-gated allowed-denoms update
    App->>Fwd: SetAllowedDenoms([USDC, USDN], signer=Auth)
    Fwd-->>App: OK/Err
  else Other heights / networks
    Note over App: No special action
  end
  App-->>ABCI: Proceed with original PreBlocker

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat: upgrade forwarding to v1.2 #403 — Prior ante wiring to integrate Forwarding’s signature verification decorator; closely mirrors current ante.go changes.
• chore: finalize v8 release #426 — App wiring for Forwarding and allowed-denoms handling; relates to the new PreBlocker height-gated update.
• V10 #531 — Changes in ante and permissioned-liquidity logic; overlaps with added MsgWithdrawRewards permission check and forwarding decorator routing.

Suggested reviewers

• boojamya

Poem

A bunny taps the ledger’s drum, hop-hop—new rules arrive!
Forwarding’s keys now join the guard, to keep our bytes alive.
At height’s chime, denoms align—USDC in queue,
Changelogs bloom like clover leaves, with Comet shining new.
Thump-thump, release 10.1.2! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description is empty and does not provide any summary or context for the changes, so it fails to describe the updates included in this release patch.	Please add a brief description summarizing the purpose of this release patch and highlighting key changes like the dependency bumps and new module wiring.
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly indicates that this PR packages the v10.1.2 patch release, which aligns with the changeset’s main purpose of updating dependencies, changelogs, and module wiring for the new version.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch john/v10.1.2

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 434f15e and ee9d835.

⛔ Files ignored due to path filters (2)

• go.mod is excluded by !**/*.mod
• go.sum is excluded by !**/*.sum, !**/*.sum

📒 Files selected for processing (8)

• .changelog/v10.1.2/dependencies/600-bump-comet.md (1 hunks)
• .changelog/v10.1.2/dependencies/600-bump-forwarding.md (1 hunks)
• .changelog/v10.1.2/summary.md (1 hunks)
• CHANGELOG.md (1 hunks)
• ante.go (4 hunks)
• ante_permissioned_liquidity.go (2 hunks)
• api/generate.sh (1 hunks)
• app.go (4 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

app.go (2)

ante.go (1)

• BankKeeper (37-40)

upgrade/constants.go (1)

• MainnetChainID (43-43)

🪛 LanguageTool

CHANGELOG.md

[grammar] ~7-~7: Use a hyphen to join words.
Context: ...1.2 Oct 14, 2025 This is a consensus breaking patch to the v10.1 Ember releas...

(QB_NEW_EN_HYPHEN)

.changelog/v10.1.2/summary.md

[grammar] ~3-~3: Use a hyphen to join words.
Context: Oct 14, 2025 This is a consensus breaking patch to the v10.1 Ember releas...

(QB_NEW_EN_HYPHEN)

---

[grammar] ~3-~3: There might be a mistake here.
Context: ...g patch to the v10.1 Ember release line.

(QB_NEW_EN)

🪛 markdownlint-cli2 (0.18.1)

CHANGELOG.md

5-5: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

.changelog/v10.1.2/summary.md

1-1: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: build
• GitHub Check: prepare
• GitHub Check: build-and-push-image

🔇 Additional comments (15)

.changelog/v10.1.2/dependencies/600-bump-comet.md (1)

1-1: LGTM!

The changelog entry correctly documents the CometBFT upgrade to address the security advisory, with appropriate links to the release and security advisory.

.changelog/v10.1.2/summary.md (1)

1-3: LGTM!

The changelog summary is clear and accurately describes the release. The static analysis hints about hyphenating "consensus breaking" are optional style improvements and not critical for changelog entries.

.changelog/v10.1.2/dependencies/600-bump-forwarding.md (1)

1-1: LGTM!

The changelog entry correctly documents the Forwarding upgrade with clear rationale and appropriate links.

CHANGELOG.md (1)

3-13: LGTM!

The changelog entry is well-formatted and consistent with the individual changelog files. It accurately documents both dependency bumps with appropriate links and rationale.

ante_permissioned_liquidity.go (2)

24-24: LGTM!

The import addition supports the new permission check for MsgWithdrawRewards.

---

65-68: LGTM!

The permission check for MsgWithdrawRewards follows the same pattern as the existing checks for MsgAddLiquidity and MsgRemoveLiquidity. The implementation is consistent and correct.

app.go (4)

32-32: LGTM!

The abci types import is necessary for the PreBlocker signature changes.

---

50-51: LGTM!

The authority and forwarding types imports support the new PreBlocker logic and AnteHandler wiring.

---

299-303: LGTM!

The AnteHandler options correctly include ForwardingKeeper and maintain consistent field ordering.

---

317-336: Verify SetAllowedDenoms implementation and upgrade parameters
Confirm:

• Block height 36887000 and denoms (USDC, USDN) match the mainnet upgrade spec.
• The forwarding keeper’s authority (set in NewKeeper) equals authoritytypes.ModuleAddress.String() and its SetAllowedDenoms method enforces this signer.

ante.go (4)

33-33: LGTM!

The forwardingkeeper import supports the new ForwardingKeeper field in HandlerOptions.

---

46-50: LGTM!

The HandlerOptions correctly includes ForwardingKeeper as a required dependency, with fields logically ordered.

---

63-65: LGTM!

The nil validation for ForwardingKeeper follows the existing pattern and ensures the keeper is properly initialized before use.

---

110-110: LGTM!

The updated call to forwarding.NewSigVerificationDecorator correctly passes the ForwardingKeeper alongside BankKeeper and the default decorator.

api/generate.sh (1)

15-15: Forwarding version consistency verified
go.mod lists github.com/noble-assets/forwarding/v2 at v2.0.3, matching api/generate.sh.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}