Fix redscript install: scc.exe nested under engine\engine - #27
Draft
nobody71004 wants to merge 7 commits into
Draft
Fix redscript install: scc.exe nested under engine\engine#27nobody71004 wants to merge 7 commits into
nobody71004 wants to merge 7 commits into
Conversation
Copy-Item of a folder into an existing Cyberpunk directory nested archives (engine\engine\tools\scc.exe instead of engine\tools\scc.exe), so Install-All failed after downloading redscript. Merge zip contents recursively and repair leftover nested folders from prior runs. Co-authored-by: XEROX710 <nobody71004@users.noreply.github.com>
Align EnqueueLoadLastCheckpoint with C++ Handle/ref (was wref), declare ClosePlayerMenu, and stop NoIntroVideos from redefining splash natives when Codeware is missing. Co-authored-by: XEROX710 <nobody71004@users.noreply.github.com>
Preserve vanilla final.redscripts (full cache wipe caused the corrupted scripts popup), reinstall client from package, strip legacy mods, and align PlayerActionTracker native return types. Co-authored-by: XEROX710 <nobody71004@users.noreply.github.com>
Users were pasting PowerShell into Command Prompt. Ship a .bat launcher plus FIX-INSTALL-NOW.ps1 that repairs natives, leftovers, and cache. Co-authored-by: XEROX710 <nobody71004@users.noreply.github.com>
Install-All skipped existing RED4ext.dll, leaving loaders that reject API v1 plugins. That made RedSync natives look invalid. Detect file version and reinstall RED4ext/Codeware when below the pinned release; FIX-INSTALL-NOW also force-installs both. Co-authored-by: XEROX710 <nobody71004@users.noreply.github.com>
PowerShell Set-Content -Encoding UTF8 injected a BOM that made scc fail on NoIntroVideos.reds. Remove that rewrite; file is optional. Co-authored-by: XEROX710 <nobody71004@users.noreply.github.com>
EnqueueLoadLastCheckpoint takes ref/Handle; GetSystemRequestsHandler returns wref, which failed redscript compilation after the native fix. Co-authored-by: XEROX710 <nobody71004@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Install-All.ps1downloaded redscript successfully, then failed with:Cause
Install-ZipToGameusedCopy-Itemof whole folders into the game root. Cyberpunk already hasengine\andr6\, so PowerShell nested the archive asengine\engine\tools\scc.exe(andr6\r6\...) instead of merging.Fix
Copy-MergeDirectoryand use it inInstall-ZipToGame(and AMM install)engine\engine,r6\r6, etc.) from earlier failed runsInstall-NPV-Template.ps1Tester note
Re-run
Install-All.bat/Install-All.ps1with the updated script. If a previous run left files underengine\engine\, the installer will move them into place automatically.