fix: Follow mode doesn't work if file is in /tmp #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, /tmp is a symlink to /private/tmp. When monitoring files in /tmp, fsnotify reports events with the resolved real path (/private/tmp/...), but the stored filepath was the symlinked path (/tmp/...). This caused the path comparison in watchEvent() to fail, preventing follow mode from detecting file changes. Fix by resolving symlinks using filepath.EvalSymlinks() after getting the absolute path in SetWatcher(). Fixes noborus#643 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: majiayu000 <[email protected]>
Owner
|
Thank you for the pull request. |
…Windows The test was failing on Windows because file handles were not properly released before t.TempDir() cleanup. This change: - Uses os.MkdirTemp instead of t.TempDir to control cleanup order - Explicitly closes watcher before document cleanup - Calls doc.requestClose() to properly close the file handle - Adds runtime.GC() and time.Sleep() to ensure handles are released - Manually removes temp directory after all resources are closed This fixes the "The process cannot access the file because it is being used by another process" error on Windows. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Owner
|
I would like to confirm whether this issue also occurs in [fsnotify/fsnotify#642]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #643
Changes
filepath.EvalSymlinksinSetWatcherso the stored file path matches what fsnotify reports