fix(screen-time): resolve active app through CompositorPlatform on KDE - #4135
Open
mdj2812 wants to merge 3 commits into
Open
fix(screen-time): resolve active app through CompositorPlatform on KDE#4135mdj2812 wants to merge 3 commits into
mdj2812 wants to merge 3 commits into
Conversation
Contributor
Author
|
CI failed due to this case: |
mdj2812
force-pushed
the
fix/screen-time-compositor-platform
branch
from
August 28, 2026 06:41
53bb97d to
1da1826
Compare
Screen time tracked focus via WaylandConnection directly, which misses the focused window on KWin-based compositors that rely on the Kwin active- window backend instead of wlr-foreign-toplevel activation state. Co-authored-by: Cursor <cursoragent@cursor.com>
Use compositor-aware active output resolution and app activation for brightness IPC and settings refocus, matching the KWin backend path already used by the taskbar and dock. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
mdj2812
force-pushed
the
fix/screen-time-compositor-platform
branch
from
August 30, 2026 07:58
1da1826 to
92238dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompositorPlatform::activeToplevel()so KWin-based compositors (e.g. KineticWE) use the Kwin active-window backend instead of wlr-foreign-toplevel activation stateCompositorPlatformwith compositor-aware active output resolution andactivateToplevelForAppId(), and use them for brightness IPC and settings refocusTest plan
noctalia msg brightness-up currenton KDE and confirm it targets the focused monitorMade with Cursor