Skip to content

feat(weather): apparent temperature - #4176

Open
galister wants to merge 1 commit into
noctalia-dev:mainfrom
galister:feels-like-temp
Open

feat(weather): apparent temperature#4176
galister wants to merge 1 commit into
noctalia-dev:mainfrom
galister:feels-like-temp

Conversation

@galister

Copy link
Copy Markdown
Contributor

Summary

I added the apparent (aka feels like) temperature to the weather panel.

I also collapsed Min temperature and Max temperature to a Temperature range so that we take up the same amount of space in the layout.

Motivation

I wanted to have a feels like temperature on the weather panel. It helps me decide which one of my 2 t-shirts to wear for the day.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging

Testing

I've tested using just run and then checked both the tool tip and the weather panel. I felt my eyes tear up as I glanced over the Feels Like temperature field. Why, do you ask? Because it's so darn hot.

Manual Coverage

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Tested with different bar positions and density settings
  • Tested at different interface scaling values
  • Tested with multiple monitors

Screenshots / Videos

image

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I ran just format with clang-format v22+ installed, or this PR has no code changes.
  • I ran the relevant build or test commands, or explained why they were not run.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I updated user-facing documentation in docs/user/ when this PR changes documented behavior or configuration, or this PR does not require documentation changes.
  • I added or updated assets/translations/en.json, or this PR adds no new user-facing strings.
  • I did not edit non-English translation files unless this PR is explicitly for translation tooling, an import/export sync, or a maintainer-requested locale change.
  • I used the existing canonical names for config keys, IPC names, paths, and identifiers.

Additional Notes


static constexpr std::size_t kForecastRowCount = 7;
static constexpr std::size_t kDetailRowCount = 7;
static constexpr std::size_t kDetailRowCount = 8;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this was 7; there were 8 rows to begin with and there are 8 rows now,
and so I went and changed this to 8.

I did not notice any change in behavior, but you might know better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant