feat(weather): apparent temperature - #4176
Open
galister wants to merge 1 commit into
Open
Conversation
galister
commented
Aug 31, 2026
|
|
||
| static constexpr std::size_t kForecastRowCount = 7; | ||
| static constexpr std::size_t kDetailRowCount = 7; | ||
| static constexpr std::size_t kDetailRowCount = 8; |
Contributor
Author
There was a problem hiding this comment.
Not sure why this was 7; there were 8 rows to begin with and there are 8 rows now,
and so I went and changed this to 8.
I did not notice any change in behavior, but you might know better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I added the apparent (aka feels like) temperature to the weather panel.
I also collapsed
Min temperatureandMax temperatureto aTemperature rangeso that we take up the same amount of space in the layout.Motivation
I wanted to have a feels like temperature on the weather panel. It helps me decide which one of my 2 t-shirts to wear for the day.
Type of Change
Testing
I've tested using
just runand then checked both the tool tip and the weather panel. I felt my eyes tear up as I glanced over the Feels Like temperature field. Why, do you ask? Because it's so darn hot.Manual Coverage
Screenshots / Videos
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.docs/user/when this PR changes documented behavior or configuration, or this PR does not require documentation changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes