Skip to content

Changes workers flag to shortfin_workers #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IanNod wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changes workers flag to shortfin_workers #1431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shortfin/python/shortfin_apps/llm/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def add_service_args(parser: argparse.ArgumentParser):
help="Number of workers to use when running in `offline` mode.",
)
parser.add_argument(
"--workers",
"--shortfin_workers",
type=int,
default=1,
help="Number of workers to use when running in `server` mode.",
Expand Down
2 changes: 1 addition & 1 deletion shortfin/python/shortfin_apps/llm/components/config_struct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ class ServerParams:
program_isolation: str = "per_call"

# Number of shortfin workers to use during generation
workers: int = 1
shortfin_workers: int = 1

# Number of fibers to create per worker
fibers_per_worker: int = 1
Expand Down
2 changes: 1 addition & 1 deletion shortfin/python/shortfin_apps/llm/components/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def remove_from_queue(self):
self.current_queue_size -= 1

def initialize_worker_and_fiber(self):
num_workers = self.server_params.workers
num_workers = self.server_params.shortfin_workers
fibers_per_worker = self.server_params.fibers_per_worker

logger.info(
Expand Down
Loading