Rename in-tree AIE passes to AMDAIE #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
requested review from
nirvedhmeshram,
MaheshRavishankar,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
makslevental
force-pushed
the
makslevental/remove-mlir-aie/rename-passes
branch
from
393d4d7 to
bc46b98
Compare
makslevental
force-pushed
the
makslevental/remove-mlir-aie/rename-passes
branch
2 times, most recently
from
aa9bb75 to
b6801b6
Compare
makslevental
force-pushed
the
makslevental/remove-mlir-aie/rename-passes
branch
from
b6801b6 to
6b85909
Compare
|
@makslevental since you asked offline if I see any existing dependency issues. Just wanted to say I could not find any so I think this is safe to land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames all of the in-tree
AIE*passes toAMDAIE*in order to prevent collision with the temporarily added out-of-treeAIE*passes added in #459.Note, in order to do this and actually change/affect/tweak the CLI args, you/we/I have to add the minimal amount of boilerplate that comes from tablegen for each pass.
Just want to stress/reiterate: this will all disappear completely as soon as we move to using only in-tree lowerings.
Fixes #477 by moving them to use in-tree passes.