Update llama_serving.md doc to reflect the latest changes #1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pravg-amd
commented
May 5, 2025
pravg-amd
commented
- Update the shortfin response format, which contains the entire json instead of just the response text.
- Update the export and compilation commands for sharded models.
1. Update the shortfin response format, which contains the entire json instead of just the response text. 2. Update the export and compilation commands for sharded models. Signed-off-by: Praveen G <[email protected]>
stbaione
reviewed
May 5, 2025
| @@ -404,7 +409,11 @@ iree-compile /path/to/output/llama3.1-405b.mlir \ | |||
| --iree-hal-target-device=hip[5] \ | |||
| --iree-hal-target-device=hip[6] \ | |||
| --iree-hal-target-device=hip[7] \ | |||
| --iree-hip-target=gfx942 | |||
| --iree-hip-target=gfx942 \ | |||
| --iree-opt-level=O3 \ | |||
There was a problem hiding this comment.
Do we know why these extra flags are required now for the compile?
There was a problem hiding this comment.
I am not aware of exactly why we need these optimizations. Without these, was running into the following error
ValueError: shortfin_iree-src/runtime/src/iree/vm/bytecode/verifier.c:344: RESOURCE_EXHAUSTED; register count overflow
These flags are used in the llama benchmark tests in sharktank. Maybe @AmosLewis can provide more insight to this ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.