Skip to content

Changes workers flag to shortfin_workers #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changes workers flag to shortfin_workers #1431

wants to merge 1 commit into from

Conversation

IanNod
Copy link
Contributor

@IanNod IanNod commented May 12, 2025 •
edited
Loading

Flag change for shortfin cli workers flag due to conflict with fastapi's workers flag

@IanNod
Changes workers flag to shortfin_workers
831a0e1 
Flag change for shortfin cli workers flag due to conflicting fastapi's workers flag
stbaione
stbaione requested changes May 13, 2025
View reviewed changes
stbaione
stbaione approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@stbaione stbaione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fyi, you'll need to pass through a cli arg to server.py and rewrite the uvicorn.run(...) step to use the import string method to enable multiple fastapi workers, when you get to that part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stbaione stbaione stbaione approved these changes

@pravg-amd pravg-amd Awaiting requested review from pravg-amd

@pdhirajkumarprasad pdhirajkumarprasad Awaiting requested review from pdhirajkumarprasad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanNod @stbaione