-
Notifications
You must be signed in to change notification settings - Fork 185
Introduce new .getSignedReferences() function of signature to help prevent signature wrapping attacks #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f9b3682
Exports C14nCanonicalization, ExclusiveCanonicalization (#471)
parallels999 c2a7d7a
Ensure that they agree on loading References from canon XML
ahacker1-securesaml b901de8
Fix specific exploits
ahacker1-securesaml ea1ad24
Clarify Comments
ahacker1-securesaml d2c9f8c
Document changelog to signedReferences API
ahacker1-securesaml b0192ab
Adds signedReferences API
ahacker1-securesaml e0c1ac1
Merge branch '6.x' into v6-minor
ahacker1-securesaml 372815b
Revert CHANGELOG.md to match v6.x
ahacker1-securesaml c63dd45
Clean up and lint
cjbarth dfb742e
Lint
cjbarth 35bd5c0
Merge branch 'wip' into v6-minor
cjbarth fc8550a
Merge branch 'wip-6.1' into pr/489
cjbarth 7689d24
- Reset .signedReferences if not all refs verified
ahacker1-securesaml 85038f6
Fix tests
cjbarth badc307
Merge remote-tracking branch 'github-desktop-SecureSAML/v6-minor' int…
cjbarth 2bf5868
lint
cjbarth 1730adb
Improve tests and comments
cjbarth b6845cf
Add deprecation; organize imports
cjbarth 1d02f00
Refactor to .getSignedReferences()
cjbarth 43a5010
Organize imports
cjbarth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,8 @@ | ||
export { SignedXml } from "./signed-xml"; | ||
export { C14nCanonicalization, C14nCanonicalizationWithComments } from "./c14n-canonicalization"; | ||
export { | ||
ExclusiveCanonicalization, | ||
ExclusiveCanonicalizationWithComments, | ||
} from "./exclusive-canonicalization"; | ||
export * from "./utils"; | ||
export * from "./types"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.