Add .signedReferences API #491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahacker1-securesaml , it may be quicker for you, but it is extra maintenance burden for me and sends the message that we still support those older versions. I'm not going to not do merges and releases, but I'm not in favor of it. What happened to the idea of breaking changes in a 7.x release that would remove the foot guns and generally clean up the API as you previously proposed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @cjbarth
Unfortunately, I've decided that the best way is to backport the API.
Because we still want other libraries to use the API even if they are still on v2.x/v3.x
It is actually a much more quicker change than the libraries upgrading to say v6.x or v7.x