Skip to content

Conversation

@phellmayr1
Copy link

Thanks for sharing this great library, it really helps us and our multiple 100k customers in the world out there! :)

I would like to propose a small improvement as you can see in my PR. It would give a great benefit, if the users of the library could do some action, if a single Tile was resized.

  • Then it is possible to react on it, e.g. show the resized Tile in some fancy looking UI
  • It would then be also possible to validate the resized Tile for some criterias

You may be wondering what the concrete use-case for us is?

  • On low memory devices(phones, old devices, ...) there is the problem, that sometimes downescaled images are just black, and there is no error being thrown (this for example also happens [very unlikely and rarely] when loading original images, so it is a very underlying problem.
  • The callback would help us, with validating if the resized Tile is fine, as we then can check if the Tile is black or not, and we can properly react on that case

@puzrin
Copy link
Member

puzrin commented Oct 21, 2022

IMO you could just override .__landTileData() to make extra call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants