Should Corepack stay in the Node.js distribution?

[github-actions]

Vote instructions:

• on the web: https://nodejs.github.io/caritat/#https://github.com/nodejs/TSC/pull/1697
• on the CLI:

  git node vote https://github.com/nodejs/TSC/pull/1697 --gpg-sign

To close the vote, at least 3 secret holder(s)¹ must run the following command: git node vote https://github.com/nodejs/TSC/pull/1697 --decrypt-key-part --post-comment

/cc @nodejs/tsc

Current estimated participation: 61.11%

Footnotes

1. secret holders are folks who have access to the private key associated with a public key on hkps://keys.openpgp.org that references an email address listed on the TSC voting member list at the time of the opening of the vote. ↩

[mcollina]

Didn't work:

remote: Resolving deltas: 100% (3/3), completed with 3 local objects.
remote: error: GH013: Repository rule violations found for refs/heads/votes/e4f313dc-6121-47bb-830d-d85f80d6ee33.
remote: Review all repository rules at https://github.com/nodejs/TSC/rules?ref=refs%2Fheads%2Fvotes%2Fe4f313dc-6121-47bb-830d-d85f80d6ee33
remote:
remote: - Commits must have verified signatures.
remote:   Found 1 violation:
remote:
remote:   8163b99b3b54ff6b9b2753a9146d5072fe7c45d1
remote:
To github.com:nodejs/TSC.git
 ! [remote rejected] HEAD -> votes/e4f313dc-6121-47bb-830d-d85f80d6ee33 (push declined due to repository rule violations)
error: failed to push some refs to 'github.com:nodejs/TSC.git'
Error: git push,[email protected]:nodejs/TSC.git,HEAD:votes/e4f313dc-6121-47bb-830d-d85f80d6ee33 failed: 1
    at ChildProcess.<anonymous> (file:///Users/matteo/.nvm/versions/node/v22.14.0/lib/node_modules/node-core-utils/node_modules/@node-core/caritat/dist/utils/runChildProcessAsync.js:32:27)
    at ChildProcess.emit (node:events:518:28)
    at maybeClose (node:internal/child_process:1101:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5)

how can I handle this?

[mcollina]

In case you wonder, the correct command is git node vote https://github.com/nodejs/TSC/pull/1697 --gpg-sign I've updated it.

[mcollina]

@nodejs/tsc please vote.

[anonrig]

In case you wonder, the correct command is git node vote https://github.com/nodejs/TSC/pull/1697 --gpg-sign I've updated it.

I couldn't sign it with SSH key. Is GPG the only way?

[aduh95]

Is GPG the only way?

No, GitHub supports different kind of signatures, including SSH and PGP.

[github-actions]

Commit 17fae0a won't be taken into account for the following reason: The commit author (RafaelGSS [email protected]) is not in the list of allowed voters.

[RafaelGSS]

Commit 17fae0a won't be taken into account for the following reason: The commit author (RafaelGSS [email protected]) is not in the list of allowed voters.

It has happened once. It's due to my name being listed as "Rafael Gonzaga" instead of "RafaelGSS". @aduh95 do you remember what we did to solve it? Does a rebase + amend solve it?