Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 21, 2025

The vote can be closed after seven days, or as soon as all voting members have sent a ballot.

Refs: #1763

Vote instructions:

To close the vote, at least 3 secret holder(s)1 must run the following command: git node vote https://github.com/nodejs/TSC/pull/1770 --decrypt-key-part --post-comment

/cc @nodejs/tsc

Current estimated participation: 100%

Footnotes

  1. secret holders are folks who have access to the private key associated with a public key on hkps://keys.openpgp.org that references an email address listed on the TSC voting member list at the time of the opening of the vote.

@marco-ippolito
Copy link
Member

marco-ippolito commented Jul 22, 2025

I get this error:

git node --version
5.14.1
Encrypting ballot with vote public key...
Commit encrypted ballot.
fatal: empty string is not a valid pathspec. please use . instead if you meant to match all paths
Error: git commit,-S,,--author,Marco Ippolito <[email protected]>,-m,vote from marco-ippolito failed: 128
    at ChildProcess.<anonymous> (file:///Users/marcoippolito/.nvm/versions/node/v22.17.0/lib/node_modules/@node-core/utils/node_modules/@node-core/caritat/dist/utils/runChildProcessAsync.js:32:27)
    at ChildProcess.emit (node:events:518:28)
    at maybeClose (node:internal/child_process:1101:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5)

Downgrading to v5.10.0 fixed it

@mcollina

This comment was marked as outdated.

@mcollina
Copy link
Member

cc @nodejs/tsc a few people are still missing… please vote, I would love to close this tomorrow

@mcollina
Copy link
Member

@BridgeAR @anonrig ping, could you vote?

@aduh95
Copy link
Contributor

aduh95 commented Jul 30, 2025

I would like to close this vote, and for this effect, I'm revealing my key part:

-----BEGIN SHAMIR KEY PART-----
eC3MgDHgDX9p4QlzzXIBaZzX78GvO+vl8ZjL9GQw8wwB
-----END SHAMIR KEY PART-----

@mcollina
Copy link
Member

I would like to close this vote, and for this effect, I'm revealing my key part:

-----BEGIN SHAMIR KEY PART-----
G2tnYNU72emt7p7pC+7HxtLdFBGFGP03ha8BOwv8oHUK
-----END SHAMIR KEY PART-----

@joyeecheung
Copy link
Member

I would like to close this vote, and for this effect, I'm revealing my key part:

-----BEGIN SHAMIR KEY PART-----
BHcLZv000EYbS022TAKCgtZZ9nypkApgQ+oHAXpuIeMH
-----END SHAMIR KEY PART-----

FYI the current tool does not seem to work well with an interactive authorization of gpg. I had to check out to another branch and did a gpg signing on a commit to cache in the authorization before I decrypt the key.

@ShogunPanda
Copy link
Contributor

I would like to close this vote, and for this effect, I'm revealing my key part:

-----BEGIN SHAMIR KEY PART-----
gbtjqRZYSAVzFJgWtcSF0QV71lfvmP1DTB3rcg7f4cMS
-----END SHAMIR KEY PART-----

@ShogunPanda
Copy link
Contributor

ShogunPanda commented Jul 30, 2025

FYI the current tool does not seem to work well with an interactive authorization of gpg. I had to check out to another branch and did a gpg signing on a commit to cache in the authorization before I decrypt the key.

I created this nodejs/caritat#60 to address this.

@mcollina
Copy link
Member

@aduh95 I'm trying to close the vote, but either I'm not doing it right, or it doesn't work.

@aduh95
Copy link
Contributor

aduh95 commented Jul 30, 2025

@mcollina gh workflow run closeVote.yml -f pr=https://github.com/nodejs/TSC/pull/1770 --repo https://github.com/nodejs/TSC

EDIT: looks like there's been a change in GH API, some comments contain unexpected \r chars: https://github.com/nodejs/TSC/actions/runs/16624227235/job/47036136934
I'll have a look at it]
EDIT2: it wasn't the \r, it was due to #1770 (comment) repeating a key part

@github-actions
Copy link
Contributor Author

github-actions bot commented Aug 1, 2025

Election results

Subject: Who should fill in the role of Vice Chair of the TSC for 2025?
End date: 2025-08-01T14:01:09.920Z
Participation: 95%

Results

Winning candidate: Both (jasnell and ruyadorno, as co-vice-chairs)

Table of results

Candidate Number of won duels
Both (jasnell and ruyadorno, as co-vice-chairs) 2
Ruy (ruyadorno) 1
James (jasnell) 0

Voting data

Participants:

Private key to decrypt ballots
-----BEGIN PRIVATE KEY-----
MIIEvgIBADANBgkqhkiG9w0BAQEFAASCBKgwggSkAgEAAoIBAQC21GukELmI+Lmo
TBWCqzGUJdV+m49zB9gyNlujGCaw62lSWq3jtnU0zWOh2OyAsp1pIeU5tBnI9aAi
PUMO6IQJjrgLzCILiOBh+iI7XkbxxXYbHU1hT+fUndC+f4GDUCXALBbpSqV6ynUo
3EqO6wZSih0OO+GdaMfYfJGjvOEEdnr4tbio1+xoI9NsRN8rxxN73UwSQ5deC+17
1MDwubte9hVNVhB7lw88jCsamYNp8mBPyZ+EgS/me4w/zMGWYyJiM5RxI9JLQ0T6
65MMd2M/W38OEWtlxfvVN4hcqueDiiMamYCojs7mRLkbzuUZbUB2h2nMMsHQMc6Q
C1A6jXCxAgMBAAECggEAL6QztmlrR290xY+p7UZZ4X5oXxj/LNzm79KtV1cEQgbe
B4k8lcFmUk+Q/kwt+K1SimI8PqiZLX4f77wh/MEHIwxvFhfn6TSOL8nD4M+E0hx/
1bnxf4GYahWDnxhPsd2RML3sbHc4nsIh/HdG8G361EhMIPjmpiN3LAjt1Ipz4jri
lzMtnNzuKskgUNmjfo1wzoKJuwUl4EhL0BQOQKbLR2LZemolIyCGx8VPayv/FvsU
W7H4xzCFvUeY8ryRNcIEMYpqfMVYq+dti/92faqfpQDvXuJbZB5ngvHtOPUJsida
jvYyT0qDI3+DjspXL47eY2i58EOhGl1WwawPPCOGhwKBgQDjH81BeC3jPOctcb8i
CbmcqVW/HfyQ7f+1cnYA7dvrgGh3jFqQGvUaxkcxtF6rkO0njxqQPevIxb9zn66g
BZprYqJJ6G5bbp7fsMvm02we6XgR27qtvDtE6Asfe9whYlOejBnMUIZTxT1surM6
yiiHXpdLhkUyQ6SwydWNx7+WVwKBgQDOEvg9BsH1zjGuaT4pXIgNCvLRo8Xai+1t
UI3teWcrvF96QJ33spkgffkib6FSWa5iXLUUKQKnkUNlmqVcb5G5FMUa92as2KsP
RndFEkT32Dq9kiHSATWS+0XgQbHeuABiTHRWbb308vP1tRBVM+M0BrwS1ecvLOAW
OfRMKb58NwKBgDc90OqPlHmkooXHGLnqq56TASwO2xNVD9DOGi13rPnGraIGHTDX
na35c+9+81e/VC8++zMCHIskrcAtooeBVWGxB8/6HH1YloPJuI5X9gA+wNl3HByN
n8zOs4Xg1lW4WKZDZTLwkvtlCd+cOWOfL+Rc+WeBLOtg0Hm/XZWyc8LZAoGBALNo
EHYQzAwT12zgcx3PUSMJxRx+WGJMMAhbeTSl3QxWk0j7uItNEcMX6S3xwaDQMuGv
lHZYvdbkwKhUWmJ/P37CdldjzB/vAf3qeyvHHAQqW/lun8MVCm9MEymKCDC+QJdT
uHUGVbpLSdlAKVgENGm280Xys7J+fxjam7UzIoNBAoGBANp66aJjwV61a2vRIwTs
RVnepjdGv5mENL2jPgU6M8cuk6uibRq1fnVYzYxRrn8zpp2/bDRjWfES44EZ34k1
DVRph+1beyrmuxWxpBtV+rJT6N57WaWr0o6O9p7DnmuXjcWYWmgwwxjgKo6a7t0i
723pjs5yVFS6stjFkzoZQwnK
-----END PRIVATE KEY-----

Footnotes

  1. Abstained.

  2. Voted for James (jasnell).

  3. Voted for Both (jasnell and ruyadorno, as co-vice-chairs).

  4. Voted for Both (jasnell and ruyadorno, as co-vice-chairs).

  5. Voted for James (jasnell).

    1. Ruy (ruyadorno).
    2. James (jasnell).
    3. Both (jasnell and ruyadorno, as co-vice-chairs).
  6. Voted for Both (jasnell and ruyadorno, as co-vice-chairs).

    1. Ruy (ruyadorno).
    2. Both (jasnell and ruyadorno, as co-vice-chairs).
    3. James (jasnell).
  7. Voted for Both (jasnell and ruyadorno, as co-vice-chairs).

    1. Both (jasnell and ruyadorno, as co-vice-chairs).
    2. James (jasnell).
    3. Ruy (ruyadorno).
    1. Ruy (ruyadorno).
    2. Both (jasnell and ruyadorno, as co-vice-chairs).
    3. James (jasnell).
  8. Voted against Both (jasnell and ruyadorno, as co-vice-chairs).

    1. Both (jasnell and ruyadorno, as co-vice-chairs).
    2. James (jasnell).
    3. Ruy (ruyadorno).
  9. Voted for Both (jasnell and ruyadorno, as co-vice-chairs).

  10. Voted for Both (jasnell and ruyadorno, as co-vice-chairs).

    1. Ruy (ruyadorno).
    2. Both (jasnell and ruyadorno, as co-vice-chairs).
    3. James (jasnell).
  11. Voted for Both (jasnell and ruyadorno, as co-vice-chairs).

  12. Abstained.

  13. Voted for Ruy (ruyadorno).

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Aug 1, 2025

Congrats to @ruyadorno and @jasnell!

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +99 to +103
"targos": {
"Ruy (ruyadorno)": 1,
"Both (jasnell and ruyadorno, as co-vice-chairs)": 0,
"James (jasnell)": 1
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Not a fan of this summary. I am not against the "Both" option. It's just that I prefer the other ones.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to suggestions, the reasoning is that whatever "duel" the tool was running (i.e. "both" vs "Ruy" or "both" vs "James"), your vote was always against the "both" option (or rather, in favor of the other option, but for the tooling it looks the same).

@jasnell
Copy link
Member

jasnell commented Aug 4, 2025

I'm going to go ahead and merge this now. Feel free to adjust the summary as necessary

@jasnell jasnell merged commit 2b51d6a into main Aug 4, 2025
1 check failed
@jasnell jasnell deleted the votes/vice-chair-2025-interim-election branch August 4, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.