Skip to content

fix: use dots in release tag and filename for ICU >= 78#96

Open
rubenaguadoc wants to merge 1 commit into
nodejs:mainfrom
DPS-ES:main
Open

fix: use dots in release tag and filename for ICU >= 78#96
rubenaguadoc wants to merge 1 commit into
nodejs:mainfrom
DPS-ES:main

Conversation

@rubenaguadoc
Copy link
Copy Markdown

Starting from ICU 78.1, the unicode-org/icu GitHub releases reverted to using dots in both the release tag (release-78.1) and the filename (icu4c-78.1-data-bin-l.zip), instead of hyphens/underscores used in versions 69-77.

URL format by version range:

  • v67-v68: release-67-1/icu4c-67.1-data-bin-l.zip (hyphens in tag, dots in file)
  • v69-v77: release-73-1/icu4c-73_1-data-bin-l.zip (hyphens in tag, underscores in file)
  • v78+: release-78.1/icu4c-78.1-data-bin-l.zip (dots in both)

Starting from ICU 78.1, the unicode-org/icu GitHub releases reverted
to using dots in both the release tag (release-78.1) and the filename
(icu4c-78.1-data-bin-l.zip), instead of hyphens/underscores used in
versions 69-77.

URL format by version range:
- v67-v68: release-67-1/icu4c-67.1-data-bin-l.zip (hyphens in tag, dots in file)
- v69-v77: release-73-1/icu4c-73_1-data-bin-l.zip (hyphens in tag, underscores in file)
- v78+:    release-78.1/icu4c-78.1-data-bin-l.zip (dots in both)
@rubenaguadoc
Copy link
Copy Markdown
Author

Hi @srl295, really appreciate the quick review here 🙏

Just checking if you have any timeline in mind for merging this and publishing a new release.
The issue affects npm install full-icu on Node.js 22.22.1+, so getting this fix out would unblock things on our side.

Happy to help with anything needed.

@srl295
Copy link
Copy Markdown
Member

srl295 commented May 5, 2026

@nschonni it's been a while since anyone released this. Anything new i need to know?

@nschonni
Copy link
Copy Markdown
Member

nschonni commented May 6, 2026

Don't think I've ever released any of the NPM packages in this org before. Quick search I found https://github.com/nodejs/undici as another project that has some automation (and CI hardening) that might make sense here.

edit: Make sense here, but not needed as part of this PR

@srl295
Copy link
Copy Markdown
Member

srl295 commented May 6, 2026

Ok sounds good. I can do a manual release at some point

@rubenaguadoc
Copy link
Copy Markdown
Author

Hi! Just checking in on this PR in case there’s anything else needed from my side — happy to help if useful 🙂

Also, do you have an approximate idea of when the manual release might happen? Just asking to get a rough idea of the timeline on my end.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants