fix: node-api version 10 support #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1641 +/- ##
=======================================
Coverage 66.09% 66.09%
=======================================
Files 3 3
Lines 2144 2144
Branches 715 715
=======================================
Hits 1417 1417
Misses 150 150
Partials 577 577 ☔ View full report in Codecov by Sentry. |
KevinEady
approved these changes
Feb 17, 2025
Merged
|
@legendecas thanks for taking a look so quickly and finding the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1639
This does not add any new version 10 APIs in C++. This fixes a semantic experimental guard with a version 10 guard.
Refs: nodejs/node#55676