Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git-node): check the tag signature and not the commit one #907

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 20, 2025

During release promotion, we want to verify the tag is signed with one of the releasers' key. The commit can be signed with a different signature (e.g. the bot's, or a soon-to-be releaser).

During release promotion, we want to verify the tag is signed with one
of the releasers' key. The commit can be signed with a different
signature (e.g. the bot's, or a soon-to-be releaser).
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (021161b) to head (9b61a56).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/run.js 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
- Coverage   80.05%   79.86%   -0.19%     
==========================================
  Files          39       39              
  Lines        4673     4684      +11     
==========================================
  Hits         3741     3741              
- Misses        932      943      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aduh95 aduh95 linked an issue Feb 28, 2025 that may be closed by this pull request
@aduh95 aduh95 linked an issue Feb 28, 2025 that may be closed by this pull request
@aduh95 aduh95 requested a review from targos February 28, 2025 16:38
@targos
Copy link
Member

targos commented Feb 28, 2025

The commit message makes me suspicious. The commit signature should have been good in my case as I had to rebase the PR locally.

@aduh95
Copy link
Contributor Author

aduh95 commented Feb 28, 2025

Yeah that's because we're getting the ${name} <${email}> string using the commit author details, instead of the committer details (the committer is the one signing the commit, not the author). Anyway, the current way is wrong on many levels, this PR is fixing that, happy to edit the commit message to something else

@aduh95 aduh95 merged commit f6dda1c into nodejs:main Mar 1, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong tag validation by git node release --promote
2 participants