-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: make console.log resilient to built-in prototypes tempering #37332
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a test for this? We are not going to check every possible way that the core can be broken by changing prototypes.
I added the test because it causes significant perf regressions to the events and streams benchmarks:, and if we are going to make that tradeoff, we should have a test otherwise it might be reverted in the future.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Significant performance regressions.
V8 9.0 update didn't fix the perf regression:
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/962/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not add more primordials in general. This is just one of the issues that arise due to having them in our code.
Fixes: #32361