fs: Performance Enhancement: Concurrent Execution of Async Tasks with Promise.all ✈

[sanjaiyan-dev]

Hello,

This pull request introduces a performance improvement by executing asynchronous tasks concurrently using Promise.all. This enhancement aims to optimize the utilization of hardware resources effectively.

This PR draws inspiration from a similar one (though not identical) in the Deno runtime, where the execution time was reduced by 85% through concurrent processing. For reference, please see: denoland/std#3363.

Additionally, a comparable pull request has been made in the Deno JavaScript runtime, as demonstrated in: denoland/std#3683.

Thank you for considering these enhancements.

[sanjaiyan-dev]

Sorry @aduh95, I didn't understand what the PromisePrototypePush function does. Please explain. Sorry for disturbing you.

[aduh95]

You need to import ArrayPrototypsePush and SafePromiseAllReturnVoid from the primordials object at the top of the file.

node/doc/contributing/primordials.md

Lines 66 to 84 in b044369

	Primordials wrap the original prototype functions with new functions that take
	the `this` value as the first argument:
	```js
	const {
	ArrayPrototypePush,
	} = primordials;
	const array = [1, 2, 3];
	ArrayPrototypePush(array, 4);
	console.log(JSON.stringify(array)); // [1,2,3,4]
	Array.prototype.push = function push(val) {
	return this.unshift(val);
	};
	ArrayPrototypePush(array, 5);
	console.log(JSON.stringify(array)); // [1,2,3,4,5]
	```

[sanjaiyan-dev]

You need to import ArrayPrototypsePush and SafePromiseAllReturnVoid from the primordials object at the top of the file.

node/doc/contributing/primordials.md

Lines 66 to 84 in b044369

	Primordials wrap the original prototype functions with new functions that take
	the `this` value as the first argument:
	```js
	const {
	ArrayPrototypePush,
	} = primordials;
	const array = [1, 2, 3];
	ArrayPrototypePush(array, 4);
	console.log(JSON.stringify(array)); // [1,2,3,4]
	Array.prototype.push = function push(val) {
	return this.unshift(val);
	};
	ArrayPrototypePush(array, 5);
	console.log(JSON.stringify(array)); // [1,2,3,4,5]
	```

Thanks for the explanation. I will fix it ASAP.

[sanjaiyan-dev]

I hope the current code changes are correct. Apologies for any inconvenience. (@aduh95 )

[H4ad]

Moving to Promise.all, this code will not probably throw EMFILE, too many open files?

[BridgeAR]

Do we have a good benchmark for this? I am surprised that this should improve the performance, I would actually expect it to be identical. In deno, there were a few changes that made it run in parallel but this should already execute things in parallel.