lib: Enhancing Performance and Readability with Switch Statements 🚀

[sanjaiyan-dev]

Hi, this PR will result in a very minimal performance improvement by changing from multiple if conditions to a switch statement. Since a switch statement utilizes a branch table (correct me if I'm wrong), the gain in performance will be marginal, but it enhances code readability.

I've attached a picture of the JavaScript benchmark I ran, and there's a YouTube video demonstrating how a switch statement can lead to performance gains. The video showcases how the C compiler optimizes switch statements, and if I'm correct, this optimization principle should also apply to the V8 engine, which JIT compiles JavaScript to assembly language: YouTube link.

[juanarbol]

Hi! Thanks for this PR, could you please add benchmarks for it? Looking good so far

Please consider reading the contributing guidelines https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#the-process-of-making-changes

[sanjaiyan-dev]

Hi! Thanks for this PR, could you please add benchmarks for it? Looking good so far

https://jsben.ch/5w6eT

[aduh95]

Hi! Thanks for this PR, could you please add benchmarks for it? Looking good so far

https://jsben.ch/5w6eT

This does not mean anything, you're not testing Node.js, and you're not even testing the same code.

[sanjaiyan-dev]

Hi! Thanks for this PR, could you please add benchmarks for it? Looking good so far

https://jsben.ch/5w6eT

This does not mean anything, you're not testing Node.js, and you're not even testing the same code.

I am extremely sorry

[H4ad]

@sanjaiyan-dev Thanks for the PR.

Some recommendations to improve your PR:

• you should update your first commit message based on our guidelines, my recommendation is to change to buffer: use switch statement instead if else
• avoid unnecessary changes, the changes related to spacing you can remove all of them and keep only the changes related to the switch.

@aduh95 We already have a benchmark for buffers read (I will trigger once the lint is fixed), I don't think that's necessary to have a micro-benchmark for if/else statements.

We also have other places with perf sensitive in the code that use a switch instead of if statements.

Something that maybe could affect/help is the position of each comparison, what is more common to read, 48bits or 32bits?

[sanjaiyan-dev]

@sanjaiyan-dev Thanks for the PR.

Some recommendations to improve your PR:

• you should update your first commit message based on our guidelines, my recommendation is to change to buffer: use switch statement instead if else
• avoid unnecessary changes, the changes related to spacing you can remove all of them and keep only the changes related to the switch.

I will make the requested changes as soon as possible. Apologies for any inconvenience caused.

[sanjaiyan-dev]

#51304

[sanjaiyan-dev]

Hi @H4ad, I'm extremely sorry. I've created a corrected PR at #51304. I apologize for any inconvenience