Skip to content

Conversation

@theanarkh
Copy link
Contributor

make start of signal_wrap reenterable.

const Signal = internalBinding('signal_wrap').Signal;
const { signals } = internalBinding('constants').os;

const signal = new Signal();
signal.start(signals.SIGUSR2);
signal.start(signals.SIGINT);
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Mar 15, 2024
@aduh95 aduh95 force-pushed the fix_signal_wrap branch from 30fff5a to d1a0bdd Compare May 12, 2024 20:14
Comment on lines 8 to 9
if (!common.isMainThread)
common.skip('Signal handling in Workers is not supported');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
if (!common.isMainThread)
common.skip('Signal handling in Workers is not supported');
common.skipIfWorker();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants