Skip to content

tls: Server should generate lazily create sessionIdContext #54298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Uzlopak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tls: Server should generate lazily create sessionIdContext #54298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions lib/_tls_wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,18 @@ const noop = () => {};
let ipServernameWarned = false;
let tlsTracingWarned = false;

let defaultSessionIdContext = null;

function lazyDefaultSessionIdContext() {
if (defaultSessionIdContext === null) {
defaultSessionIdContext = crypto.createHash('sha1')
.update(process.argv.length === 1 ? process.argv[0] : process.argv.join(' '))
.digest('hex')
.slice(0, 32);
}
return defaultSessionIdContext;
}

// Server side times how long a handshake is taking to protect against slow
// handshakes being used for DoS.
function onhandshakestart(now) {
Expand Down Expand Up @@ -1472,10 +1484,7 @@ Server.prototype.setSecureContext = function(options) {
if (options.sessionIdContext) {
this.sessionIdContext = options.sessionIdContext;
} else {
this.sessionIdContext = crypto.createHash('sha1')
.update(process.argv.join(' '))
.digest('hex')
.slice(0, 32);
this.sessionIdContext = lazyDefaultSessionIdContext();
}

if (options.sessionTimeout)
Expand Down Expand Up @@ -1570,10 +1579,7 @@ Server.prototype.setOptions = deprecate(function(options) {
if (options.sessionIdContext) {
this.sessionIdContext = options.sessionIdContext;
} else {
this.sessionIdContext = crypto.createHash('sha1')
.update(process.argv.join(' '))
.digest('hex')
.slice(0, 32);
this.sessionIdContext = lazyDefaultSessionIdContext();
}
if (options.pskCallback) this[kPskCallback] = options.pskCallback;
if (options.pskIdentityHint) this[kPskIdentityHint] = options.pskIdentityHint;
Expand Down