Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update devcontainer to the latest schema #54347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

meta: update devcontainer to the latest schema #54347

wants to merge 2 commits into from

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Aug 12, 2024 •
edited
Loading

This PR updates the devcontainer config to that of the latest schema.

The dev container configuration is either located under .devcontainer/devcontainer.json or stored as a .devcontainer.json file (note the dot-prefix) in the root of your project.

IMO .devcontainer.json at the root makes more sense, as it is a similar file to to .editorconfig, which is also stored at the root.

Additionally, extensions and settings where renamed to customizations/vscode/extensions and customizations/vscode/settings, respectively. The latest schema for the vscode customizations is available here.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 12, 2024
@avivkeller avivkeller mentioned this pull request Sep 4, 2024
Closed
@bharath063
Fix for ARM64
aa7548c 
Co-Authored-By: bharath063 <[email protected]>
@avivkeller avivkeller added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. arm Issues and PRs related to the ARM platform. labels Sep 4, 2024
@avivkeller
Copy link
Member Author

CC @nodejs/platform-arm

@avivkeller avivkeller added the review wanted PRs that need reviews. label Sep 7, 2024
@avivkeller avivkeller removed the review wanted PRs that need reviews. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avivkeller @nodejs-github-bot