meta: update devcontainer to the latest schema #54347
Open
+26
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
Co-Authored-By: bharath063 <[email protected]>
avivkeller
added
commit-queue-squash
|
CC @nodejs/platform-arm |
|
Bump for reviews |
richardlau
reviewed
May 10, 2025
| } | ||
| } | ||
| }, | ||
| "image": "nodejs/devcontainer:nightly" |
There was a problem hiding this comment.
Are people using this? The image hasn't been updated in two years: https://hub.docker.com/r/nodejs/devcontainer
There was a problem hiding this comment.
I'm not sure, but it's what we've been recommending.
There was a problem hiding this comment.
@richardlau if your concern is addressed, can this land?
It's been several months
There was a problem hiding this comment.
It's not blocking. I don't use this.
jasnell
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the devcontainer config to that of the latest schema.
IMO
.devcontainer.jsonat the root makes more sense, as it is a similar file to to.editorconfig, which is also stored at the root.Additionally,
extensionsandsettingswhere renamed tocustomizations/vscode/extensionsandcustomizations/vscode/settings, respectively. The latest schema for the vscode customizations is available here.