Skip to content

doc: add notice to execArgv #55177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

doc: add notice to execArgv #55177

wants to merge 2 commits into from
+5 −0

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Sep 30, 2024 •
edited
Loading

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Sep 30, 2024
@avivkeller avivkeller requested a review from cjihrig September 30, 2024 13:31
@avivkeller avivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 30, 2024
@cjihrig cjihrig requested review from mcollina and aduh95 October 3, 2024 15:39
@avivkeller avivkeller added the review wanted PRs that need reviews. label Oct 30, 2024
@cjihrig cjihrig removed their request for review December 5, 2024 02:30
@avivkeller
Copy link
Member Author

Bump @mcollina @aduh95 for reviews

mcollina
mcollina reviewed May 10, 2025
View reviewed changes
doc/api/test.md
**Note:** A number of CLI flags will not function properly when used with
`execArgv`, and users should avoid using it unless they have a deep
understanding of its implications. In general, bug reports regarding this
behavior will not be investigated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have the list somewhere, right? We should link it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I checked I don't think we did.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, we should probably add one or this note really is not going to be very useful for folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina left review comments

@jasnell jasnell jasnell left review comments

@aduh95 aduh95 Awaiting requested review from aduh95

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. review wanted PRs that need reviews. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avivkeller @nodejs-github-bot @mcollina @jasnell