module: expose resolveLoadAndCache API
#55756
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
module
atlowChemi
reviewed
Nov 7, 2024
| it was imported from the `parentURL` in the current process. If the module was | ||
| already imported before `resolveLoadAndCache` is called, the cached version is | ||
| returned; if not, it will populate the cache so future calls to | ||
| `resolveLoadAndCache` or `import` do re-do the work. |
There was a problem hiding this comment.
Shouldn't this be:
Suggested change
| `resolveLoadAndCache` or `import` do re-do the work. | |
| `resolveLoadAndCache` or `import` do not re-do the work. |
aduh95
commented
Nov 7, 2024
|
|
||
| > Stability: 1 - Experimental | ||
|
|
||
| * `specifier` {string|URL} Customization hooks to be registered; this should be |
There was a problem hiding this comment.
Suggested change
| * `specifier` {string|URL} Customization hooks to be registered; this should be | |
| * `specifier` {string|URL} Module to resolve and load; this should be |
| @@ -392,6 +392,24 @@ ObjectFreeze(compileCacheStatus); | |||
| const constants = { __proto__: null, compileCacheStatus }; | |||
| ObjectFreeze(constants); | |||
|
|
|||
| async function resolveLoadAndCache(specifier, base = 'data:', importAttributes = kEmptyObject, conditions) { | |||
| const cascadedLoader = require('internal/modules/esm/loader').getOrInitializeCascadedLoader(); | |||
| // TODO: this should hit the cache (and populate it if it finds nothing) | |||
There was a problem hiding this comment.
This is already doing that, no? I see gets and sets
There was a problem hiding this comment.
Or, it appears to do for ModuleLoader but not CustomizedModuleLoader. Is that what you mean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as draft as I'd like to get some feedback on the API design first. /cc @nodejs/loaders