Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add BaseObjectPtr nullptr operations #56585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: add BaseObjectPtr nullptr operations #56585

wants to merge 1 commit into from
+81 −15

Conversation

legendecas
Copy link
Member

Allow comparing a BaseObjectPtr or implicitly construct a
BaseObjectPtr with nullptr.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 13, 2025
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov Codecov

This comment was marked as outdated.

Sign in to view
jasnell
jasnell reviewed Jan 13, 2025
View reviewed changes
addaleax
addaleax reviewed Jan 13, 2025
View reviewed changes
@legendecas legendecas force-pushed the base-object-ptr-nullptr branch from 7d35dba to 06cb322 Compare January 22, 2025 11:07
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@legendecas
src: add BaseObjectPtr nullptr operations
0d69bb8 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.
@legendecas legendecas force-pushed the base-object-ptr-nullptr branch from 06cb322 to 0d69bb8 Compare January 23, 2025 09:47
@legendecas
Copy link
Member Author

Rebased to fix the failures that were on the main branch

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64681/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax left review comments

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legendecas @nodejs-github-bot @jasnell @addaleax