-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
events: refactored emit to improve performance #56741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Refactored error handling logic for clarity and efficiency. Streamlined error inspection and stringification process. Enhanced stack trace handling with minimal performance overhead. Simplified listener iteration and result handling in emit method. Fixes: nodejs#53056 Signed-off-by: KUNAL KUMAR <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56741 +/- ##
==========================================
- Coverage 89.21% 89.20% -0.01%
==========================================
Files 662 662
Lines 191968 191958 -10
Branches 36955 36952 -3
==========================================
- Hits 171269 171242 -27
- Misses 13535 13552 +17
Partials 7164 7164
🚀 New features to boost your workflow:
|
hello , I did a node version benchmark in my local, is this healthy? @anonrig @targos Be aware that when doing many comparisons the risk of a false-positive result increases.
all result: https://ctxt.io/2/AAB4UTAXEQ |
why running String-decoder benchmark ? |
These changes improve the overall efficiency and maintainability of the emit method
Fixes: #53056