deps: V8: cherry-pick 9ab40592f697 #56781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message:
[riscv] Flush icache in both local and remote harts
Fix the I-Cache flush flag according to the implementation of flush_icache_mm in Linux kernel.
Change-Id: I6e6b1f56c377c2c0a629e170737bfac6c357ce8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6080611
Commit-Queue: Yahan Lu (LuYahan) <[email protected]>
Reviewed-by: Ji Qiu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#97673}
Refs: v8/v8@9ab4059
|
Review requested:
|
nodejs-github-bot
added
build
|
v20.x should also need this, I have created a manual backport: #56782 |
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Jan 27, 2025
- Switch compiler to clang, this workarounds https://archriscv.felixc.at/.status/log.htm?url=logs/389-ds-base/389-ds-base-3.1.1-3.log See more details in riscv-forks/electron#7 - Cherry-pick icache flush fix, upstreamed: - nodejs/node#56781 - nodejs/node#56782 - Should still need nocheck
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Jan 27, 2025
- Switch compiler to clang, this workarounds https://archriscv.felixc.at/.status/log.htm?url=logs/389-ds-base/389-ds-base-3.1.1-3.log See more details in riscv-forks/electron#7 - Cherry-pick icache flush fix, upstreamed: - nodejs/node#56781 - nodejs/node#56782 - Should still need nocheck
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Jan 28, 2025
- Switch compiler to clang, this workarounds https://archriscv.felixc.at/.status/log.htm?url=logs/389-ds-base/389-ds-base-3.1.1-3.log See more details in riscv-forks/electron#7 - Cherry-pick icache flush fix, upstreamed: - nodejs/node#56781 - nodejs/node#56782 - Should still need nocheck
targos
approved these changes
Jan 28, 2025
targos
added
riscv64
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstream v8 commit fixes SIGILLs in v8 on riscv64 like riscv-forks/electron#6
Main branch, v23.x, v22.x should need this. I didn't check on older branches.
CC @luyahan
Original commit message:
Refs: v8/v8@9ab4059