Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update options to include signal in filehandle.writeFile() #56804

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

y-hsgw
Copy link

@y-hsgw y-hsgw commented Jan 28, 2025

This PR updates the documentation for filehandle.writeFile() to include the signal option in the options parameter.

This is my first pull request to this repository, and I understand there may be areas for improvement. I would appreciate your review and feedback.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jan 28, 2025
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 29, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 30, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/56804
✔  Done loading data for nodejs/node/pull/56804
----------------------------------- PR info ------------------------------------
Title      doc: update options to include signal in filehandle.writeFile() (#56804)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     y-hsgw:docs-fs -> nodejs:main
Labels     doc, fs, author ready
Commits    2
 - doc: update options to include signal in filehandle.writeFile()
 - Merge branch 'nodejs:main' into docs-fs
Committers 2
 - Hasegawa-Yukihiro <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/56804
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56804
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - Merge branch 'nodejs:main' into docs-fs
   ℹ  This PR was created on Tue, 28 Jan 2025 14:29:33 GMT
   ✔  Approvals: 4
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56804#pullrequestreview-2578752550
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/56804#pullrequestreview-2579739573
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/56804#pullrequestreview-2582127211
   ✔  - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/56804#pullrequestreview-2583749716
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/13054622419

@richardlau richardlau removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants