Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: disallow copy/move fns/constructors #56811

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

src: disallow copy/move fns/constructors #56811

wants to merge 3 commits into from
+7 −1

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jan 29, 2025

Following @addaleax's recommendation on #56452 (comment), let's disallow copy/move functions and constructors on MaybeStackBuffer.

@anonrig anonrig requested review from jasnell and addaleax January 29, 2025 00:53
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 29, 2025
@anonrig anonrig force-pushed the yagiz/disallow-copy-move branch 2 times, most recently from 6eb550e to a7cb2f1 Compare January 29, 2025 00:59
@anonrig anonrig force-pushed the yagiz/disallow-copy-move branch from a7cb2f1 to 434c008 Compare January 29, 2025 01:00
juanarbol
juanarbol approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

legendecas
legendecas reviewed Jan 29, 2025
View reviewed changes
src/util.h Outdated Show resolved Hide resolved
@anonrig @legendecas
Update src/util.h
678bb61 
Co-authored-by: Chengzhong Wu <[email protected]>
@anonrig anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 29, 2025
addaleax
addaleax approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should include the class name in the commit message

@lemire
Copy link
Member

lemire commented Jan 29, 2025

@anonrig I pushed a minor fix.

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.21%. Comparing base (e346323) to head (bc7b209).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/debug_utils-inl.h 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56811      +/-   ##
==========================================
- Coverage   89.21%   89.21%   -0.01%     
==========================================
  Files         663      663              
  Lines      192012   192002      -10     
  Branches    36928    36919       -9     
==========================================
- Hits       171306   171285      -21     
- Misses      13580    13587       +7     
- Partials     7126     7130       +4
Files with missing lines Coverage Δ
src/util.h 91.22% <ø> (ø)
src/debug_utils-inl.h 85.84% <0.00%> (ø)

... and 43 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64834/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas left review comments

@juanarbol juanarbol juanarbol approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@lemire lemire lemire approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anonrig @lemire @nodejs-github-bot @jasnell @addaleax @legendecas @juanarbol