test: adjust check to use OpenSSL sec level #56819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some checks should use the sec level instead of the OpenSSL version, adjust test-tls-client-mindhsize.js Signed-off-by: Michael Dawson <[email protected]>
nodejs-github-bot
added
needs-ci
|
Test run to validate its ok against different OpenSSL versions - https://ci.nodejs.org/job/node-test-commit-linux-containered/48718/ (EDIT, all passed) |
jasnell
approved these changes
Jan 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56819 +/- ##
==========================================
- Coverage 89.21% 89.21% -0.01%
==========================================
Files 663 663
Lines 192002 192002
Branches 36932 36927 -5
==========================================
- Hits 171291 171289 -2
- Misses 13574 13580 +6
+ Partials 7137 7133 -4 |
lpinca
approved these changes
Jan 30, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
mhdawson
added
the
commit-queue
jasnell
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 46132bd |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2025
Some checks should use the sec level instead of the OpenSSL version, adjust test-tls-client-mindhsize.js Signed-off-by: Michael Dawson <[email protected]> PR-URL: #56819 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some checks should use the sec level instead of the OpenSSL version, adjust test-tls-client-mindhsize.js