build: increase minimum Xcode version to 16.1 #56824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same version as required by the Chromium/V8 project. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5973484
targos
added
the
semver-major
nodejs-github-bot
added
build
|
@nodejs/build @nodejs/platform-macos @nodejs/tsc |
anonrig
approved these changes
Jan 30, 2025
richardlau
reviewed
Jan 30, 2025
There was a problem hiding this comment.
The table for the release binaries still lists Xcode 14 for macOS arm64 on L166.
Line 166 in 4749a7f
That's because the release infra is still setup this way (Ryan didn't want to change it in the middle of the current release process) |
richardlau
approved these changes
Jan 30, 2025
targos
added a commit
to targos/node
that referenced
this pull request
Jan 30, 2025
We have to remove `macos-13` as it doesn't have Xcode 16 available. Refs: nodejs#56824
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
We have to remove `macos-13` as it doesn't have Xcode 16 available. Refs: #56824 PR-URL: #56831 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
jasnell
approved these changes
Jan 31, 2025
anonrig
approved these changes
Jan 31, 2025
aduh95
added
the
author ready
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ed52ab9 |
targos
added a commit
that referenced
this pull request
Feb 2, 2025
We have to remove `macos-13` as it doesn't have Xcode 16 available. Refs: #56824 PR-URL: #56831 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same version as required by the Chromium/V8 project.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5973484