Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Add enum handle for ToStringHelper + formatting #56829

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: Add enum handle for ToStringHelper + formatting #56829

wants to merge 1 commit into from
+24 −21

Conversation

wooffie
Copy link
Contributor

@wooffie wooffie commented Jan 30, 2025

Fixes: #56666

Now ToStringHelper handles enums not like bool variables

P.S. I used clang-format for this file, but it changed a lot, I can reset formatting (if I do it wrong...)

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ToStringHelper wrong logic with enum types
2 participants
@wooffie @nodejs-github-bot