Skip to content

test: reduce flakiness on test-net-write-fully-async-buffer #56981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 9, 2025

Reduces flakiness of the proposed test

Ref: #56971 (comment)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 9, 2025
@anonrig anonrig requested a review from jasnell February 9, 2025 19:31
@anonrig anonrig closed this Feb 9, 2025
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (a2aa6ca) to head (72eae6d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56981      +/-   ##
==========================================
- Coverage   89.14%   89.13%   -0.02%     
==========================================
  Files         665      665              
  Lines      193179   193179              
  Branches    37197    37196       -1     
==========================================
- Hits       172213   172185      -28     
  Misses      13728    13728              
- Partials     7238     7266      +28     

see 32 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants