-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
esm: unflag --experimental-wasm-modules #57038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -667,10 +667,17 @@ imported from the same path. | |||||
|
||||||
## Wasm modules | ||||||
|
||||||
<!-- YAML | ||||||
changes: | ||||||
- version: | ||||||
- v24.0.0 | ||||||
pr-url: https://github.com/nodejs/node/pull/57038 | ||||||
description: Wasm modules no longer require the `--experimental-wasm-modules` flag. | ||||||
--> | ||||||
|
||||||
> Stability: 1 - Experimental | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
Importing WebAssembly modules is supported under the | ||||||
`--experimental-wasm-modules` flag, allowing any `.wasm` files to be | ||||||
Importing WebAssembly modules is supported, allowing any `.wasm` files to be | ||||||
imported as normal modules while also supporting their module imports. | ||||||
|
||||||
This integration is in line with the | ||||||
|
@@ -686,7 +693,7 @@ console.log(M); | |||||
executed under: | ||||||
|
||||||
```bash | ||||||
node --experimental-wasm-modules index.mjs | ||||||
node index.mjs | ||||||
``` | ||||||
|
||||||
would provide the exports interface for the instantiation of `module.wasm`. | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -466,10 +466,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() { | |
kAllowedInEnvvar); | ||
AddAlias("--loader", "--experimental-loader"); | ||
AddOption("--experimental-modules", "", NoOp{}, kAllowedInEnvvar); | ||
AddOption("--experimental-wasm-modules", | ||
"experimental ES Module support for webassembly modules", | ||
&EnvironmentOptions::experimental_wasm_modules, | ||
kAllowedInEnvvar); | ||
AddOption("--experimental-wasm-modules", "", NoOp{}, kAllowedInEnvvar); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think "unflag an experimental feature" should start with switching the default value to be BTW, if we are going to make this a no-op, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree, if having WASM module enabled breaks something, it's useful to be able to disable it. We can make the falg a no-op in another major |
||
AddOption("--experimental-import-meta-resolve", | ||
"experimental ES Module import.meta.resolve() parentURL support", | ||
&EnvironmentOptions::experimental_import_meta_resolve, | ||
|
Uh oh!
There was an error while loading. Please reload this page.